From 0cefea2fb3b033e7fe6b43e04f04b29faec43794 Mon Sep 17 00:00:00 2001 From: Raito Bezarius Date: Wed, 4 Oct 2023 02:08:12 +0200 Subject: [PATCH] python3Packages.msgpack: be mindful of borgbackup via passthru.tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Unfortunately, BorgBackup, a backupping software is very sensible to MsgPack versions to the extent of pinning patch-level versions… I believe it's not totally absurd if they do it as they seems to consider it dangerous to do otherwise. As a result, I would like to ensure that python3Packages.msgpack are gated with that piece of software ; of course, in case of security updates, we can consider extracting the patches if reasonable or just breaking all dependents. --- pkgs/development/python-modules/msgpack/default.nix | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkgs/development/python-modules/msgpack/default.nix b/pkgs/development/python-modules/msgpack/default.nix index 18287c64198..d44166b82f7 100644 --- a/pkgs/development/python-modules/msgpack/default.nix +++ b/pkgs/development/python-modules/msgpack/default.nix @@ -4,6 +4,7 @@ , pytestCheckHook , pythonOlder , setuptools +, borgbackup }: buildPythonPackage rec { @@ -30,6 +31,12 @@ buildPythonPackage rec { "msgpack" ]; + passthru.tests = { + # borgbackup is sensible to msgpack versions: https://github.com/borgbackup/borg/issues/3753 + # please be mindful before bumping versions. + inherit borgbackup; + }; + meta = with lib; { description = "MessagePack serializer implementation"; homepage = "https://github.com/msgpack/msgpack-python";