skawarePackages.skalibs: empty default path
If `PATH` is unset, the exec wrappers in skalibs set a default path to `/usr/bin:bin`. This has very unfortunate effects when you e.g. try to run tests on CI in an empty environment (minus tools explicitely provided by nix with absolute store paths), because suddenly binaries from outside are picked up again, especially on non-NixOS. Even on NixOS, /bin/sh provides another escape hatch if it’s available from PATH. But on systems like Ubuntu or MacOS (which most CI systems run on), this picks up all the non-nix binaries.
This commit is contained in:
parent
fc6d1e0ebf
commit
14f812aeef
|
@ -18,6 +18,9 @@ buildPackage {
|
|||
"--dynlibdir=\${lib}/lib"
|
||||
"--includedir=\${dev}/include"
|
||||
"--sysdepdir=\${lib}/lib/skalibs/sysdeps"
|
||||
# Empty the default path, which would be "/usr/bin:bin".
|
||||
# It would be set when PATH is empty. This hurts hermeticity.
|
||||
"--with-default-path="
|
||||
];
|
||||
|
||||
postInstall = ''
|
||||
|
|
Loading…
Reference in a new issue