From 331f45f7bb5a90ce2b5516a9ae34da566f54e69c Mon Sep 17 00:00:00 2001
From: DavHau <42246742+DavHau@users.noreply.github.com>
Date: Wed, 13 Nov 2019 03:41:30 +0700
Subject: [PATCH] update contributors documentation for nix-review (#73217)

Useful for newcomers who want to do their review after committing and then stumbling across the PR checklist.

* replace nix-shell with nix run
---
 doc/contributing/submitting-changes.xml | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/doc/contributing/submitting-changes.xml b/doc/contributing/submitting-changes.xml
index f0971162411..0a652aef923 100644
--- a/doc/contributing/submitting-changes.xml
+++ b/doc/contributing/submitting-changes.xml
@@ -298,14 +298,17 @@ Additional information.
 
    <para>
     review changes from pull request number 12345:
-<screen>nix-shell -p nix-review --run "nix-review pr 12345"</screen>
+<screen>nix run nixpkgs.nix-review -c nix-review pr 12345</screen>
    </para>
 
    <para>
     review uncommitted changes:
-<screen>nix-shell -p nix-review --run "nix-review wip"</screen>
+<screen>nix run nixpkgs.nix-review -c nix-review wip</screen>
    </para>
-  </section>
+
+   <para>
+    review changes from last commit:
+<screen>nix run nixpkgs.nix-review -c nix-review rev HEAD</screen>
 
   <section xml:id="submitting-changes-tested-execution">
    <title>Tested execution of all binary files (usually in <filename>./result/bin/</filename>)</title>