From 3c2d7dbfdfc0c8a69752539cdd6330bf9f922e2c Mon Sep 17 00:00:00 2001 From: zowoq <59103226+zowoq@users.noreply.github.com> Date: Mon, 23 Aug 2021 14:55:51 +1000 Subject: [PATCH] buildGoPackage: warn if buildFlagsArray is used --- pkgs/development/go-packages/generic/default.nix | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkgs/development/go-packages/generic/default.nix b/pkgs/development/go-packages/generic/default.nix index 6eaeee2a123..7c4d173b937 100644 --- a/pkgs/development/go-packages/generic/default.nix +++ b/pkgs/development/go-packages/generic/default.nix @@ -43,8 +43,9 @@ , CGO_ENABLED ? go.CGO_ENABLED -# needed for buildFlags warning +# needed for buildFlags{,Array} warning , buildFlags ? "" +, buildFlagsArray ? "" , meta ? {}, ... } @ args: @@ -260,6 +261,6 @@ let } // meta; }); in -lib.warnIf (buildFlags != "") - "Use the `ldflags` and/or `tags` attributes instead of `buildFlags`" +lib.warnIf (buildFlags != "" || buildFlagsArray != "") + "Use the `ldflags` and/or `tags` attributes instead of `buildFlags`/`buildFlagsArray`" package