From 43b8ad27aa0a39dc7882c526e7b8ce18933b5cdf Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Sun, 22 May 2022 17:30:21 +0100 Subject: [PATCH] ncftp: add -fcommon workaround Workaround build failure on -fno-common toolchains like upstream gcc-10. Otherwise build fails as: ld: bookmark.o: (.bss+0x20): multiple definition of `gBm'; gpshare.o:(.bss+0x0): first defined here --- pkgs/tools/networking/ncftp/default.nix | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkgs/tools/networking/ncftp/default.nix b/pkgs/tools/networking/ncftp/default.nix index a43d5f4a88c..8156caad7c3 100644 --- a/pkgs/tools/networking/ncftp/default.nix +++ b/pkgs/tools/networking/ncftp/default.nix @@ -13,6 +13,12 @@ stdenv.mkDerivation rec { enableParallelBuilding = true; + # Workaround build failure on -fno-common toolchains like upstream + # gcc-10. Otherwise build fails as: + # ld: bookmark.o: (.bss+0x20): multiple definition of `gBm'; + # gpshare.o:(.bss+0x0): first defined here + NIX_CFLAGS_COMPILE = "-fcommon"; + preConfigure = '' find -name Makefile.in | xargs sed -i '/^TMPDIR=/d'