b12f/nixpkgs
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

nsc: disable check phase on darwin

Browse source 
nsc is currently marked as broken on darwin because it's check phase
does not pass. However, it builds and works fine.

The check phase failure is due to a test in nsc stripping `-` from some
test output to remove some table formatting. This accidentally removes
`-` in a filesystem path and makes a test fail that expects the output
to contain a specific path.

This should be fixed upstream in nsc, but no need to mark darwin as
broken when it actually does build and work okay.
This commit is contained in:
Connor Brewster 2023-10-04 16:48:23 -05:00
parent bc16dfe4b3
commit 47a059731e
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
pkgs/tools/system/nsc/default.nix
View file

@ -39,12 +39,22 @@ buildGoModule rec {
export HOME=$(mktemp -d)
'';
# Tests currently fail on darwin because of a test in nsc which
# expects command output to contain a specific path. However
# the test strips table formatting from the command output in a naive way
# that removes all the table characters, including '-'.
# The nix build directory looks something like:
# /private/tmp/nix-build-nsc-2.8.1.drv-0/nsc_test2000598938/keys
# Then the `-` are removed from the path unintentionally and the test fails.
# This should be fixed upstream to avoid mangling the path when
# removing the table decorations from the command output.
doCheck = !stdenv.isDarwin;
meta = {
description = "A tool for creating NATS account and user access configurations";
homepage = "https://github.com/nats-io/nsc";
license = with lib.licenses; [ asl20 ];
maintainers = with lib.maintainers; [ cbrewster ];
mainProgram = "nsc";
broken = stdenv.isDarwin;
};
}