From 4a9dba6c444b0eb1933b7495dd373173f0034d55 Mon Sep 17 00:00:00 2001 From: Robert Scott Date: Sat, 17 Oct 2020 20:23:54 +0100 Subject: [PATCH] python3Packages.Theano: add pythonImportsCheck this not only gives us a "hint" of test coverage, but also proves the fix from #97597 allows import of theano from within a sandboxed build --- pkgs/development/python-modules/Theano/default.nix | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkgs/development/python-modules/Theano/default.nix b/pkgs/development/python-modules/Theano/default.nix index cc2b681e415..ce32e42e471 100644 --- a/pkgs/development/python-modules/Theano/default.nix +++ b/pkgs/development/python-modules/Theano/default.nix @@ -68,7 +68,9 @@ in buildPythonPackage rec { --replace 'StrParam(default_dnn_base_path)' 'StrParam('\'''${cudnn}'\''')' ''; - preCheck = '' + # needs to be postFixup so it runs before pythonImportsCheck even when + # doCheck = false (meaning preCheck would be disabled) + postFixup = '' mkdir -p check-phase export HOME=$(pwd)/check-phase ''; @@ -81,6 +83,8 @@ in buildPythonPackage rec { checkInputs = [ nose ]; propagatedBuildInputs = [ numpy numpy.blas scipy six libgpuarray_ ]; + pythonImportsCheck = [ "theano" ]; + meta = with stdenv.lib; { homepage = "http://deeplearning.net/software/theano/"; description = "A Python library for large-scale array computation";