From 6d95b1aebba5a1c6452406d6c3c75c84ac9e37ea Mon Sep 17 00:00:00 2001 From: Silvan Mosberger Date: Wed, 6 Sep 2023 13:58:14 +0200 Subject: [PATCH 1/2] workflows/backport: Fix link and reword --- .github/workflows/backport.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/backport.yml b/.github/workflows/backport.yml index 81fc5306fea..131a52b0560 100644 --- a/.github/workflows/backport.yml +++ b/.github/workflows/backport.yml @@ -31,5 +31,5 @@ jobs: pull_description: |- Bot-based backport to `${target_branch}`, triggered by a label in #${pull_number}. - * [ ] Before merging, ensure that this backport complies with the [Criteria for Backporting](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#criteria-for-backporting-changes). - * Even as a non-commiter, if you find that it does not comply, leave a comment. + * [ ] Before merging, ensure that this backport is [acceptable for the release](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-acceptable-for-releases). + * Even as a non-commiter, if you find that it is not acceptable, leave a comment. From 433f935d1036aefe3b18e19c901986d6299f91bd Mon Sep 17 00:00:00 2001 From: Silvan Mosberger Date: Wed, 6 Sep 2023 13:58:45 +0200 Subject: [PATCH 2/2] CONTRIBUTING.md: Reword changes acceptable for backport It wasn't entirely clear if the list was acceptable or not from the wording. --- CONTRIBUTING.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 616fd4c2201..e30a4bb0f95 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -483,17 +483,17 @@ The oldest supported release (`YYMM`) can be found using nix-instantiate --eval -A lib.trivial.oldestSupportedRelease ``` -The release branches should generally not receive any breaking changes, both for the Nix expressions and derivations. -So these changes are acceptable to backport: -- New packages, modules and functions -- Security fixes -- Package version updates - - Patch versions with fixes - - Minor versions with new functionality, but no breaking changes +The release branches should generally only receive backwards-compatible changes, both for the Nix expressions and derivations. +Here are some examples of backwards-compatible changes that are okay to backport: +- ✔️ New packages, modules and functions +- ✔️ Security fixes +- ✔️ Package version updates + - ✔️ Patch versions with fixes + - ✔️ Minor versions with new functionality, but no breaking changes In addition, major package version updates with breaking changes are also acceptable for: -- Services that would fail without up-to-date client software, such as `spotify`, `steam`, and `discord` -- Security critical applications, such as `firefox` and `chromium` +- ✔️ Services that would fail without up-to-date client software, such as `spotify`, `steam`, and `discord` +- ✔️ Security critical applications, such as `firefox` and `chromium` ### Changes causing mass rebuilds [mass-rebuild]: #changes-causing-mass-rebuilds