From 6b74da4cc33971a438bff8928bb053f3ffba4375 Mon Sep 17 00:00:00 2001 From: benaryorg Date: Sun, 11 Jun 2023 20:11:45 +0000 Subject: [PATCH] ndi: unpackPhase without interpolation of src The `unpackPhase` as of the previous commit did interpolate the result of the `src` on a nix level. However for any overrides (`overrideAttrs`) to work on the source, for instance to update to a newer version locally, the `src` environment variable of `stdenv` must be used. Otherwise the old, upstream, version will still be pulled in as a dependency and ultimately used for building, which will fail if the old version is not present, or will just deploy the old version if the old version was already downloaded (`requireFile` causes special semi-non-idempotent issues here). Further information was provided in a GitHub comment: https://github.com/NixOS/nixpkgs/issues/219578#issuecomment-1586322972 Signed-off-by: benaryorg --- pkgs/development/libraries/ndi/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/development/libraries/ndi/default.nix b/pkgs/development/libraries/ndi/default.nix index 1c15455b6ad..9cd0d186302 100644 --- a/pkgs/development/libraries/ndi/default.nix +++ b/pkgs/development/libraries/ndi/default.nix @@ -28,7 +28,7 @@ stdenv.mkDerivation rec { buildInputs = [ avahi ]; unpackPhase = '' - unpackFile ${src} + unpackFile $src echo y | ./${installerName}.sh sourceRoot="NDI SDK for Linux"; '';