From 75b08e3624e51b11247c1482bf5378d5d8be7b5f Mon Sep 17 00:00:00 2001 From: Profpatsch Date: Thu, 10 Mar 2022 11:11:23 +0100 Subject: [PATCH] modules/github-runner: Improve description of `url` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We spent a whole afternoon debugging this, because upstream has very bad software quality and the error messages were incredibly misleading. So let’s document it for the sanity of other people. Btw, I think the implementation of our module is pretty brittle, especially the part about diffing tokens to check whether they changed. We should rather just request a new builder registration every time, it’s not that much overhead, and always set `replace` so it is idempotent. --- .../services/continuous-integration/github-runner.nix | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/nixos/modules/services/continuous-integration/github-runner.nix b/nixos/modules/services/continuous-integration/github-runner.nix index c3bd8f99c57..a7645e1f56e 100644 --- a/nixos/modules/services/continuous-integration/github-runner.nix +++ b/nixos/modules/services/continuous-integration/github-runner.nix @@ -34,6 +34,14 @@ in Repository to add the runner to. Changing this option triggers a new runner registration. + + IMPORTANT: If your token is org-wide (not per repository), you need to + provide a github org link, not a single repository, so do it like this + https://github.com/nixos, not like this + https://github.com/nixos/nixpkgs. + Otherwise, you are going to get a 404 NotFound + from POST https://api.github.com/actions/runner-registration + in the configure script. ''; example = "https://github.com/nixos/nixpkgs"; };