b12f/nixpkgs
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Merge pull request #173835 from aaronjheng/check-flags

Browse source 
Stop using ineffective check flags
This commit is contained in:
Mario Rodas 2022-05-28 11:12:56 -05:00 committed by GitHub
parent ac5e91ffb2 dad03081b1
commit 7d179051fc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 24 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkgs/applications/networking/cluster/kube-router/default.nix
View file

@ -22,8 +22,6 @@ buildGoModule rec {
"-X github.com/cloudnativelabs/kube-router/pkg/version.BuildDate=Nix"
];
checkFlags = [ "-short" ];
passthru.tests.version = testers.testVersion {
package = kube-router;
};

3
pkgs/applications/networking/cluster/temporal/default.nix
View file

@ -17,7 +17,8 @@ buildGoModule rec {
ldflags = [ "-s" "-w" ];
checkFlags = [ "-short" ];
# There too many integration tests.
doCheck = false;
installPhase = ''
runHook preInstall

4
pkgs/development/tools/goconvey/default.nix
View file

@ -17,7 +17,9 @@ buildGoModule rec {
ldflags = [ "-s" "-w" ];
checkFlags = [ "-short" ];
preCheck = ''
buildFlagsArray+="-short"
'';
meta = {
description = "Go testing in the browser. Integrates with `go test`. Write behavioral tests in Go";

4
pkgs/servers/monitoring/prometheus/mysqld-exporter.nix
View file

@ -24,7 +24,9 @@ buildGoModule rec {
];
# skips tests with external dependencies, e.g. on mysqld
checkFlags = [ "-short" ];
preCheck = ''
buildFlagsArray+="-short"
'';
meta = with lib; {
description = "Prometheus exporter for MySQL server metrics";

16
pkgs/tools/admin/docker-credential-gcr/default.nix
View file

@ -1,4 +1,4 @@
{ lib, buildGoModule, fetchFromGitHub, testers, docker-credential-gcr }:
{ lib, buildGoModule, fetchFromGitHub, fetchpatch, testers, docker-credential-gcr }:
buildGoModule rec {
pname = "docker-credential-gcr";
@ -11,6 +11,18 @@ buildGoModule rec {
sha256 = "sha256-1AUs8Gt2Qw8BJk2zwRcazVl+POkPSy9e1jW9Mk/0rx8=";
};
patches = [
(fetchpatch {
name = "fix-TestGet_GCRCredentials.patch";
url = "https://github.com/GoogleCloudPlatform/docker-credential-gcr/commit/a0c080e58bbfdeb0aa24e66551c4e8b0359bf178.patch";
sha256 = "sha256-aXp/1kNaxqQDPszC7pO+qP7ZBWHjpVljUHiKFnnDWuM=";
})
];
postPatch = ''
rm -rf ./test
'';
vendorSha256 = "sha256-e7XNTizZYp/tS7KRvB9KxY3Yurphnm6Ehz4dHZNReK8=";
CGO_ENABLED = 0;
@ -21,8 +33,6 @@ buildGoModule rec {
"-X github.com/GoogleCloudPlatform/docker-credential-gcr/config.Version=${version}"
];
checkFlags = [ "-short" ];
passthru.tests.version = testers.testVersion {
package = docker-credential-gcr;
command = "docker-credential-gcr version";

4
pkgs/tools/misc/cloud-sql-proxy/default.nix
View file

@ -15,7 +15,9 @@ buildGoModule rec {
vendorSha256 = "sha256-yxqLGDqdu9vX3ykHq7Kzf8oBH1ydltZkiWNWWM2l0Aw=";
checkFlags = [ "-short" ];
preCheck = ''
buildFlagsArray+="-short"
'';
meta = with lib; {
description = "An authenticating proxy for Second Generation Google Cloud SQL databases";