From 810c9c6a0ea9a021426acf8ae3f2bcfbde545ef7 Mon Sep 17 00:00:00 2001
From: Nicolas Berbiche <nicolas@normie.dev>
Date: Wed, 3 Mar 2021 00:59:52 -0500
Subject: [PATCH] lib/modules: provide error message when imports contains a
 list

---
 lib/modules.nix | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/modules.nix b/lib/modules.nix
index 04b65d791b5..fb6fe48395d 100644
--- a/lib/modules.nix
+++ b/lib/modules.nix
@@ -23,6 +23,7 @@ let
     isAttrs
     isBool
     isFunction
+    isList
     isString
     length
     mapAttrs
@@ -188,6 +189,9 @@ rec {
       loadModule = args: fallbackFile: fallbackKey: m:
         if isFunction m || isAttrs m then
           unifyModuleSyntax fallbackFile fallbackKey (applyIfFunction fallbackKey m args)
+        else if isList m then
+          let defs = [{ file = fallbackFile; value = m; }]; in
+          throw "Module imports can't be nested lists. Perhaps you meant to remove one level of lists? Definitions: ${showDefs defs}"
         else unifyModuleSyntax (toString m) (toString m) (applyIfFunction (toString m) (import m) args);
 
       /*