From 8e09dec9eefee49d4cedc8be7b1ac01862b9ca67 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stanis=C5=82aw=20Pitucha?= Date: Fri, 24 Mar 2023 22:02:48 +1100 Subject: [PATCH] librep: fix darwin build Functions coming from ctype.h get inlines, but are not static when compiling this with clang. This causes duplicates when linking. Force an older gnu standard to prevent the issue. --- pkgs/development/libraries/librep/default.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkgs/development/libraries/librep/default.nix b/pkgs/development/libraries/librep/default.nix index 3a17d0279dc..e67d47d4502 100644 --- a/pkgs/development/libraries/librep/default.nix +++ b/pkgs/development/libraries/librep/default.nix @@ -31,6 +31,9 @@ stdenv.mkDerivation rec { readline ]; + # ensure libsystem/ctype functions don't get duplicated when using clang + configureFlags = lib.optionals stdenv.isDarwin [ "CFLAGS=-std=gnu89" ]; + setupHook = ./setup-hook.sh; meta = with lib;{ @@ -44,7 +47,6 @@ stdenv.mkDerivation rec { license = licenses.gpl2Plus; maintainers = [ maintainers.AndersonTorres ]; platforms = platforms.unix; - broken = stdenv.isDarwin; # never built on Hydra https://hydra.nixos.org/job/nixpkgs/trunk/librep.x86_64-darwin }; } # TODO: investigate fetchFromGithub