From 8fb56a487fe57e420209d9f37a085fcc89a5d108 Mon Sep 17 00:00:00 2001 From: Sirio Balmelli Date: Thu, 15 Oct 2020 16:07:12 +0200 Subject: [PATCH] python3Packages.pyelftools: disable tests on Darwin af27072 broke the build on Darwin. There does not seem to be any way to sanely enable tests on Darwin. Tests initially fail because of missing 'greadelf' expected by test/run_readelf_tests.py. This is fixed by: - adding 'binutils-unwrapped' to checkInputs - hardlinking 'readelf' to 'greadelf' in a temp bin dir - exporting temp bin dir to PATH This leads to further test failures because of 'readelf' version mismatch causing output inconsistencies. See test/run_readelf_tests.py:31 for further details. Signed-off-by: Sirio Balmelli --- pkgs/development/python-modules/pyelftools/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/development/python-modules/pyelftools/default.nix b/pkgs/development/python-modules/pyelftools/default.nix index 08fba705aa8..51e1886f1d0 100644 --- a/pkgs/development/python-modules/pyelftools/default.nix +++ b/pkgs/development/python-modules/pyelftools/default.nix @@ -15,7 +15,7 @@ buildPythonPackage rec { sha256 = "sha256-O7l1kj0k8bOSOtZJVzS674oVnM+X3oP00Ybs0qjb64Q="; }; - doCheck = stdenv.is64bit; + doCheck = stdenv.is64bit && !stdenv.isDarwin; checkPhase = '' patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" test/external_tools/readelf