giflib: clean up
- use `makeFlags` to override `PREFIX` - change spacing and split some attributes into multiple lines for cleaner diffs and blames - add `meta.homepage` - format the expression - remove unused arguments - move `nativeBuildInputs` to more common place
This commit is contained in:
parent
c516ad1ee1
commit
9096d43ade
|
@ -1,8 +1,15 @@
|
|||
{ lib, stdenv, fetchurl, fetchpatch, xmlto, docbook_xml_dtd_412, docbook_xsl, libxml2, fixDarwinDylibNames, pkgsStatic }:
|
||||
{ stdenv
|
||||
, lib
|
||||
, fetchurl
|
||||
, fetchpatch
|
||||
, fixDarwinDylibNames
|
||||
, pkgsStatic
|
||||
}:
|
||||
|
||||
stdenv.mkDerivation rec {
|
||||
pname = "giflib";
|
||||
version = "5.2.1";
|
||||
|
||||
src = fetchurl {
|
||||
url = "mirror://sourceforge/giflib/giflib-${version}.tar.gz";
|
||||
sha256 = "1gbrg03z1b6rlrvjyc6d41bc8j1bsr7rm8206gb1apscyii5bnii";
|
||||
|
@ -14,33 +21,39 @@ stdenv.mkDerivation rec {
|
|||
url = "https://src.fedoraproject.org/rpms/giflib/raw/2e9917bf13df114354163f0c0211eccc00943596/f/CVE-2022-28506.patch";
|
||||
sha256 = "sha256-TBemEXkuox8FdS9RvjnWcTWPaHRo4crcwSR9czrUwBY=";
|
||||
})
|
||||
] ++ lib.optional stdenv.hostPlatform.isDarwin
|
||||
] ++ lib.optionals stdenv.hostPlatform.isDarwin [
|
||||
# https://sourceforge.net/p/giflib/bugs/133/
|
||||
(fetchpatch {
|
||||
# https://sourceforge.net/p/giflib/bugs/133/
|
||||
name = "darwin-soname.patch";
|
||||
url = "https://sourceforge.net/p/giflib/bugs/_discuss/thread/4e811ad29b/c323/attachment/Makefile.patch";
|
||||
sha256 = "12afkqnlkl3n1hywwgx8sqnhp3bz0c5qrwcv8j9hifw1lmfhv67r";
|
||||
extraPrefix = "./";
|
||||
});
|
||||
})
|
||||
];
|
||||
|
||||
postPatch = ''
|
||||
substituteInPlace Makefile \
|
||||
--replace 'PREFIX = /usr/local' 'PREFIX = ${builtins.placeholder "out"}'
|
||||
''
|
||||
# Upstream build system does not support NOT building shared libraries.
|
||||
+ lib.optionalString stdenv.hostPlatform.isStatic ''
|
||||
nativeBuildInputs = lib.optionals stdenv.isDarwin [
|
||||
fixDarwinDylibNames
|
||||
];
|
||||
|
||||
makeFlags = [
|
||||
"PREFIX=${builtins.placeholder "out"}"
|
||||
];
|
||||
|
||||
postPatch = lib.optionalString stdenv.hostPlatform.isStatic ''
|
||||
# Upstream build system does not support NOT building shared libraries.
|
||||
sed -i '/all:/ s/libgif.so//' Makefile
|
||||
sed -i '/all:/ s/libutil.so//' Makefile
|
||||
sed -i '/-m 755 libgif.so/ d' Makefile
|
||||
sed -i '/ln -sf libgif.so/ d' Makefile
|
||||
'';
|
||||
|
||||
nativeBuildInputs = lib.optionals stdenv.isDarwin [ fixDarwinDylibNames ];
|
||||
|
||||
passthru.tests.static = pkgsStatic.giflib;
|
||||
passthru.tests = {
|
||||
static = pkgsStatic.giflib;
|
||||
};
|
||||
|
||||
meta = {
|
||||
description = "A library for reading and writing gif images";
|
||||
homepage = "https://giflib.sourceforge.net/";
|
||||
platforms = lib.platforms.unix;
|
||||
license = lib.licenses.mit;
|
||||
maintainers = with lib.maintainers; [ ];
|
||||
|
|
Loading…
Reference in a new issue