b12f/nixpkgs
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

tiscamera: clean up

Browse source 
- use pkg-config instead of pkgconfig alias
- use placeholders for cmakeFlags
- do not skip build rpath
- udev replacements no longer apply 47d4fb246b

There are some misplaced dependencies like gobject-introspection and orc that should probably go to nativeBuildInputs but upstream detects them incorrectly.
This commit is contained in:
Jan Tojnar 2020-09-02 03:50:40 +02:00
parent cc4f18ec47
commit 9a1f60994b
No known key found for this signature in database
GPG key ID: 7FAB2A15F7A607A4
1 changed files with 12 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
pkgs/os-specific/linux/tiscamera/default.nix
View file

@ -2,7 +2,7 @@
, stdenv
, fetchFromGitHub
, cmake
, pkgconfig
, pkg-config
, pcre
, tinyxml
, libusb1
@ -31,7 +31,7 @@ stdenv.mkDerivation rec {
nativeBuildInputs = [
cmake
pkgconfig
pkg-config
];
buildInputs = [
@ -51,47 +51,31 @@ stdenv.mkDerivation rec {
libuuid
];
cmakeFlags = [
"-DBUILD_ARAVIS=OFF" # For GigE support. Won't need it as our camera is usb.
"-DBUILD_GST_1_0=ON"
"-DBUILD_TOOLS=ON"
"-DBUILD_V4L2=ON"
"-DBUILD_LIBUSB=ON"
"-DTCAM_INSTALL_UDEV=${placeholder "out"}/lib/udev/rules.d"
"-DTCAM_INSTALL_UVCDYNCTRL=${placeholder "out"}/share/uvcdynctrl/data/199e"
"-DTCAM_INSTALL_GST_1_0=${placeholder "out"}/lib/gstreamer-1.0"
"-DTCAM_INSTALL_GIR=${placeholder "out"}/share/gir-1.0"
"-DTCAM_INSTALL_TYPELIB=${placeholder "out"}/lib/girepository-1.0"
"-DTCAM_INSTALL_SYSTEMD=${placeholder "out"}/etc/systemd/system"
# There are gobject introspection commands launched as part of the build. Those have a runtime
# dependency on `libtcam` (which itself is built as part of this build). In order to allow
# that, we set the dynamic linker's path to point on the build time location of the library.
"-DCMAKE_SKIP_BUILD_RPATH=OFF"
];
postPatch = ''
substituteInPlace ./data/udev/80-theimagingsource-cameras.rules.in \
--replace "/usr/bin/uvcdynctrl" "${libwebcam}/bin/uvcdynctrl" \
--replace "/path/to/tiscamera/uvc-extensions" "$out/share/uvcdynctrl/data/199e"
substituteInPlace ./src/BackendLoader.cpp \
--replace '"libtcam-v4l2.so"' "\"$out/lib/tcam-0/libtcam-v4l2.so\"" \
--replace '"libtcam-aravis.so"' "\"$out/lib/tcam-0/libtcam-aravis.so\"" \
--replace '"libtcam-libusb.so"' "\"$out/lib/tcam-0/libtcam-libusb.so\""
'';
preConfigure = ''
cmakeFlagsArray=(
$cmakeFlagsArray
"-DCMAKE_INSTALL_PREFIX=$out"
"-DTCAM_INSTALL_UDEV=$out/lib/udev/rules.d"
"-DTCAM_INSTALL_UVCDYNCTRL=$out/share/uvcdynctrl/data/199e"
"-DTCAM_INSTALL_GST_1_0=$out/lib/gstreamer-1.0"
"-DTCAM_INSTALL_GIR=$out/share/gir-1.0"
"-DTCAM_INSTALL_TYPELIB=$out/lib/girepository-1.0"
"-DTCAM_INSTALL_SYSTEMD=$out/etc/systemd/system"
)
'';
# There are gobject introspection commands launched as part of the build. Those have a runtime
# dependency on `libtcam` (which itself is built as part of this build). In order to allow
# that, we set the dynamic linker's path to point on the build time location of the library.
preBuild = ''
export LD_LIBRARY_PATH=$PWD/src''${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH
'';
meta = with lib; {
description = "The Linux sources and UVC firmwares for The Imaging Source cameras";
homepage = "https://github.com/TheImagingSource/tiscamera";