From 5df1c24a273e39ee940a546d8076cbff6cb49faa Mon Sep 17 00:00:00 2001 From: Randy Eckenrode Date: Fri, 7 Jul 2023 07:21:56 -0600 Subject: [PATCH] rustc: remove Darwin special-casing An attempt to remove it was made in #106886, but there was a build failure. Since that failure no longer occurs, remove it now. Based on thefloweringash/nixpkgs@19042366485d2141daad7ec3e0dd1ec309cc78b1. --- pkgs/development/compilers/rust/1_70.nix | 5 +---- pkgs/development/compilers/rust/default.nix | 7 ------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/pkgs/development/compilers/rust/1_70.nix b/pkgs/development/compilers/rust/1_70.nix index 8c91ed01009..2a22c4643e5 100644 --- a/pkgs/development/compilers/rust/1_70.nix +++ b/pkgs/development/compilers/rust/1_70.nix @@ -15,7 +15,6 @@ , CoreFoundation, Security, SystemConfiguration , pkgsBuildTarget, pkgsBuildBuild, pkgsBuildHost , makeRustPlatform -, llvmPackages_11 , llvmPackages_16, llvm_16 } @ args: @@ -27,8 +26,6 @@ import ./default.nix { llvmSharedForHost = pkgsBuildHost.llvmPackages_16.libllvm.override { enableSharedLibraries = true; }; llvmSharedForTarget = pkgsBuildTarget.llvmPackages_16.libllvm.override { enableSharedLibraries = true; }; - llvmBootstrapForDarwin = llvmPackages_11; - # For use at runtime llvmShared = llvm_16.override { enableSharedLibraries = true; }; @@ -60,4 +57,4 @@ import ./default.nix { rustcPatches = [ ]; } -(builtins.removeAttrs args [ "pkgsBuildHost" "llvmPackages_11" "llvmPackages_16" "llvm_16"]) +(builtins.removeAttrs args [ "pkgsBuildTarget" "pkgsBuildBuild" "pkgsBuildHost" "llvmPackages_16" "llvm_16"]) diff --git a/pkgs/development/compilers/rust/default.nix b/pkgs/development/compilers/rust/default.nix index 0324aca1e4e..35f5ab79c10 100644 --- a/pkgs/development/compilers/rust/default.nix +++ b/pkgs/development/compilers/rust/default.nix @@ -5,7 +5,6 @@ , bootstrapHashes , selectRustPackage , rustcPatches ? [] -, llvmBootstrapForDarwin , llvmShared , llvmSharedForBuild , llvmSharedForHost @@ -16,7 +15,6 @@ , buildPackages , newScope, callPackage , CoreFoundation, Security, SystemConfiguration -, pkgsBuildTarget, pkgsBuildBuild , makeRustPlatform }: @@ -69,11 +67,6 @@ in # Use boot package set to break cycle inherit (bootstrapRustPackages) cargo rustc; - } // lib.optionalAttrs (stdenv.cc.isClang && stdenv.hostPlatform == stdenv.buildPlatform) { - stdenv = llvmBootstrapForDarwin.stdenv; - pkgsBuildBuild = pkgsBuildBuild // { targetPackages.stdenv = llvmBootstrapForDarwin.stdenv; }; - pkgsBuildHost = pkgsBuildBuild // { targetPackages.stdenv = llvmBootstrapForDarwin.stdenv; }; - pkgsBuildTarget = pkgsBuildTarget // { targetPackages.stdenv = llvmBootstrapForDarwin.stdenv; }; }); rustfmt = self.callPackage ./rustfmt.nix { inherit Security;