From a94a2370bb1831dc212e8567bd3e273fd0b5be7f Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Sun, 28 Nov 2021 16:04:23 +0000 Subject: [PATCH] noice: fix build against ncurses-6.3 Without the change the build on upcoming `ncurses-6.3` fails as: noice.c:377:9: error: format not a string literal and no format arguments [-Werror=format-security] 377 | printw(str); | ^~~~~~ --- pkgs/applications/misc/noice/default.nix | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkgs/applications/misc/noice/default.nix b/pkgs/applications/misc/noice/default.nix index 73648d896d0..e67346c5171 100644 --- a/pkgs/applications/misc/noice/default.nix +++ b/pkgs/applications/misc/noice/default.nix @@ -12,6 +12,12 @@ stdenv.mkDerivation rec { sha256 = "0975j4m93s9a21pazwdzn4gqhkngwq7q6ghp0q8a75r6c4fb7aar"; }; + postPatch = '' + # Add support for ncurses-6.3. Can be dropped with 0.9 release. + # Fixed upstream at: https://git.2f30.org/noice/commit/53c35e6b340b7c135038e00057a198f03cb7d7cf.html + substituteInPlace noice.c --replace 'printw(str);' 'printw("%s", str);' + ''; + configFile = optionalString (conf!=null) (builtins.toFile "config.def.h" conf); preBuild = optionalString (conf!=null) "cp ${configFile} config.def.h";