b12f/nixpkgs
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

libvirt-glib: fixup build after glib update

Browse source 
I see only one instance of the warning where *equality* of strings
is tested and char signedness differs.  That one seems perfectly safe.
```
../libvirt-gconfig/libvirt-gconfig-domain-capabilities-os.c: In function 'search_firmwares':
../libvirt-gconfig/libvirt-gconfig-domain-capabilities-os.c:70:26: warning: pointer targets in passing argument 1 of 'strcmp' differ in signedness [-Wpointer-sign]
   70 |     if (!g_str_equal(node->name, "enum"))
/nix/store/fmqcm52w0p5jmzdbjjskwjiwyj9kqic9-glib-2.74.1-dev/include/glib-2.0/glib/ghash.h:165:39: note: in definition of macro 'g_str_equal'
  165 | #define g_str_equal(v1, v2) (strcmp ((v1), (v2)) == 0)
      |                                       ^~
```
This commit is contained in:
Vladimír Čunát 2022-11-08 11:07:29 +01:00
parent 7e3e9bb620
commit c35a930454
No known key found for this signature in database
GPG key ID: E747DF1F9575A3AA
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkgs/development/libraries/libvirt-glib/default.nix
View file

@ -55,6 +55,9 @@ stdenv.mkDerivation rec {
strictDeps = true;
# https://gitlab.com/libvirt/libvirt-glib/-/issues/4
NIX_CFLAGS_COMPILE = [ "-Wno-error=pointer-sign" ];
meta = with lib; {
description = "Library for working with virtual machines";
longDescription = ''