From cb2891b8c88705dfa5092cf992b7f64ae04da781 Mon Sep 17 00:00:00 2001 From: "Noah D. Brenowitz" Date: Wed, 12 May 2021 00:39:29 -0700 Subject: [PATCH] python3Packages.scikitlearn: disable flaky tests * Disable all tests of the NuSVC estimator that use memmap'd data * build in serial on darwin Resolves #121988 --- .../python-modules/scikit-learn/default.nix | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/pkgs/development/python-modules/scikit-learn/default.nix b/pkgs/development/python-modules/scikit-learn/default.nix index dfce61df6c6..94140f228f3 100644 --- a/pkgs/development/python-modules/scikit-learn/default.nix +++ b/pkgs/development/python-modules/scikit-learn/default.nix @@ -66,10 +66,23 @@ buildPythonPackage rec { doCheck = !stdenv.isAarch64; - # Skip test_feature_importance_regression - does web fetch - disabledTests = [ "test_feature_importance_regression" ]; + disabledTests = [ + # Skip test_feature_importance_regression - does web fetch + "test_feature_importance_regression" + ]; - pytestFlagsArray = [ "-n" "$NIX_BUILD_CORES" "--pyargs" "sklearn" ]; + pytestFlagsArray = [ + # verbose build outputs needed to debug hard-to-reproduce hydra failures + "-v" + "--pyargs" "sklearn" + # NuSVC memmap tests causes segmentation faults in certain environments + # (e.g. Hydra Darwin machines) related to a long-standing joblib issue + # (https://github.com/joblib/joblib/issues/563). See also: + # https://github.com/scikit-learn/scikit-learn/issues/17582 + "-k 'not (NuSVC and memmap)'" + ] ++ lib.optionals (!stdenv.isDarwin) [ + "-n" "$NIX_BUILD_CORES" + ]; preCheck = '' cd $TMPDIR