From 9eafe4319c247d3211c6c0783bb59003357f6064 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Mon, 25 Jul 2022 21:33:04 -0700 Subject: [PATCH 01/13] gnulib: add gnulib-longdouble-redirect.patch This patch adds gnulib-longdouble-redirect.patch, which is a subset of gnulib commit 776af40e09b476a41073131a90022572f448c189. This patch must be applied to the copy of gnulib which is vendored within a few packages, when compiling for platforms that use longdouble-redirection (a glibc-specific feature). Without it, compile failures mentioning "__LDBL_REDIR1_DECL" will occur. Currently there are two packages which need this patch to their vendored gnulib: gettext and gnused. Both projects have merged a fixed version of gnulib but have not yet made a release with the fix. We can drop this patch as soon as both of those projects are version-bumped. --- pkgs/development/tools/gnulib/default.nix | 11 +++ .../gnulib/gnulib-longdouble-redirect.patch | 72 +++++++++++++++++++ 2 files changed, 83 insertions(+) create mode 100644 pkgs/development/tools/gnulib/gnulib-longdouble-redirect.patch diff --git a/pkgs/development/tools/gnulib/default.nix b/pkgs/development/tools/gnulib/default.nix index afc91cb6030..a55589c5a63 100644 --- a/pkgs/development/tools/gnulib/default.nix +++ b/pkgs/development/tools/gnulib/default.nix @@ -26,6 +26,17 @@ stdenv.mkDerivation { # do not change headers to not update all vendored build files dontFixup = true; + passthru = { + # This patch is used by multiple other packages (currently: + # gnused, gettext) which contain vendored copies of gnulib. + # Without it, compilation will fail with error messages about + # "__LDBL_REDIR1_DECL" or similar on platforms with longdouble + # redirects (currently powerpc64). Once all of those other + # packages make a release with a newer gnulib we can drop this + # patch. + longdouble-redirect-patch = ./gnulib-longdouble-redirect.patch; + }; + meta = with lib; { description = "Central location for code to be shared among GNU packages"; homepage = "https://www.gnu.org/software/gnulib/"; diff --git a/pkgs/development/tools/gnulib/gnulib-longdouble-redirect.patch b/pkgs/development/tools/gnulib/gnulib-longdouble-redirect.patch new file mode 100644 index 00000000000..f684292dc8b --- /dev/null +++ b/pkgs/development/tools/gnulib/gnulib-longdouble-redirect.patch @@ -0,0 +1,72 @@ + +Below is the subset of gnulib commit +776af40e09b476a41073131a90022572f448c189 which deals with long double +redirects. The rest of that commit has been removed. + +diff --git a/lib/cdefs.h b/lib/cdefs.h +index fd72b7b..4383e70 100644 +--- a/lib/cdefs.h ++++ b/lib/cdefs.h +@@ -483,7 +493,37 @@ + # include + #endif + +-#if defined __LONG_DOUBLE_MATH_OPTIONAL && defined __NO_LONG_DOUBLE_MATH ++#if __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI == 1 ++# ifdef __REDIRECT ++ ++/* Alias name defined automatically. */ ++# define __LDBL_REDIR(name, proto) ... unused__ldbl_redir ++# define __LDBL_REDIR_DECL(name) \ ++ extern __typeof (name) name __asm (__ASMNAME ("__" #name "ieee128")); ++ ++/* Alias name defined automatically, with leading underscores. */ ++# define __LDBL_REDIR2_DECL(name) \ ++ extern __typeof (__##name) __##name \ ++ __asm (__ASMNAME ("__" #name "ieee128")); ++ ++/* Alias name defined manually. */ ++# define __LDBL_REDIR1(name, proto, alias) ... unused__ldbl_redir1 ++# define __LDBL_REDIR1_DECL(name, alias) \ ++ extern __typeof (name) name __asm (__ASMNAME (#alias)); ++ ++# define __LDBL_REDIR1_NTH(name, proto, alias) \ ++ __REDIRECT_NTH (name, proto, alias) ++# define __REDIRECT_NTH_LDBL(name, proto, alias) \ ++ __LDBL_REDIR1_NTH (name, proto, __##alias##ieee128) ++ ++/* Unused. */ ++# define __REDIRECT_LDBL(name, proto, alias) ... unused__redirect_ldbl ++# define __LDBL_REDIR_NTH(name, proto) ... unused__ldbl_redir_nth ++ ++# else ++_Static_assert (0, "IEEE 128-bits long double requires redirection on this platform"); ++# endif ++#elif defined __LONG_DOUBLE_MATH_OPTIONAL && defined __NO_LONG_DOUBLE_MATH + # define __LDBL_COMPAT 1 + # ifdef __REDIRECT + # define __LDBL_REDIR1(name, proto, alias) __REDIRECT (name, proto, alias) +@@ -492,6 +532,8 @@ + # define __LDBL_REDIR1_NTH(name, proto, alias) __REDIRECT_NTH (name, proto, alias) + # define __LDBL_REDIR_NTH(name, proto) \ + __LDBL_REDIR1_NTH (name, proto, __nldbl_##name) ++# define __LDBL_REDIR2_DECL(name) \ ++ extern __typeof (__##name) __##name __asm (__ASMNAME ("__nldbl___" #name)); + # define __LDBL_REDIR1_DECL(name, alias) \ + extern __typeof (name) name __asm (__ASMNAME (#alias)); + # define __LDBL_REDIR_DECL(name) \ +@@ -502,11 +544,13 @@ + __LDBL_REDIR1_NTH (name, proto, __nldbl_##alias) + # endif + #endif +-#if !defined __LDBL_COMPAT || !defined __REDIRECT ++#if (!defined __LDBL_COMPAT && __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI == 0) \ ++ || !defined __REDIRECT + # define __LDBL_REDIR1(name, proto, alias) name proto + # define __LDBL_REDIR(name, proto) name proto + # define __LDBL_REDIR1_NTH(name, proto, alias) name proto __THROW + # define __LDBL_REDIR_NTH(name, proto) name proto __THROW ++# define __LDBL_REDIR2_DECL(name) + # define __LDBL_REDIR_DECL(name) + # ifdef __REDIRECT + # define __REDIRECT_LDBL(name, proto, alias) __REDIRECT (name, proto, alias) From 1fa5ff7d5d126e3a9d43781483af2edf6c4833d0 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Mon, 25 Jul 2022 21:35:32 -0700 Subject: [PATCH 02/13] gnused: apply gnulib.passthru.longdouble-redirect-patch --- pkgs/tools/text/gnused/default.nix | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/pkgs/tools/text/gnused/default.nix b/pkgs/tools/text/gnused/default.nix index f493e4f358d..35e707acaf9 100644 --- a/pkgs/tools/text/gnused/default.nix +++ b/pkgs/tools/text/gnused/default.nix @@ -1,4 +1,5 @@ -{ lib, stdenv, fetchurl, perl }: +{ lib, stdenv, fetchurl, perl +, gnulib }: stdenv.mkDerivation rec { pname = "gnused"; @@ -12,6 +13,13 @@ stdenv.mkDerivation rec { outputs = [ "out" "info" ]; nativeBuildInputs = [ perl ]; + + patches = [ + # this change to gnused's vendored copy of gnulib is already + # merged upstream; we can drop this patch on the next version bump + gnulib.passthru.longdouble-redirect-patch + ]; + preConfigure = "patchShebangs ./build-aux/help2man"; # Prevents attempts of running 'help2man' on cross-built binaries. From 810c6c387ba97d726cb61999a9f474b7f62a1e7f Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Mon, 25 Jul 2022 21:35:38 -0700 Subject: [PATCH 03/13] gettext: apply gnulib.passthru.longdouble-redirect-patch --- pkgs/development/libraries/gettext/default.nix | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/pkgs/development/libraries/gettext/default.nix b/pkgs/development/libraries/gettext/default.nix index 81f7abc90a3..5443f1eeac0 100644 --- a/pkgs/development/libraries/gettext/default.nix +++ b/pkgs/development/libraries/gettext/default.nix @@ -1,4 +1,6 @@ -{ stdenv, lib, fetchurl, fetchpatch, libiconv, xz, bash }: +{ stdenv, lib, fetchurl, fetchpatch, libiconv, xz, bash +, gnulib +}: # Note: this package is used for bootstrapping fetchurl, and thus # cannot use fetchpatch! All mutable patches (generated by GitHub or @@ -45,6 +47,14 @@ stdenv.mkDerivation rec { '' + lib.optionalString stdenv.hostPlatform.isCygwin '' sed -i -e "s/\(cldr_plurals_LDADD = \)/\\1..\/gnulib-lib\/libxml_rpl.la /" gettext-tools/src/Makefile.in sed -i -e "s/\(libgettextsrc_la_LDFLAGS = \)/\\1..\/gnulib-lib\/libxml_rpl.la /" gettext-tools/src/Makefile.in + '' + + # This change to gettext's vendored copy of gnulib is already + # merged upstream; we can drop this patch on the next version + # bump. It must be applied twice because gettext vendors gnulib + # not once, but twice! + '' + patch -p2 -d gettext-tools/gnulib-lib/ < ${gnulib.passthru.longdouble-redirect-patch} + patch -p2 -d gettext-tools/libgrep/ < ${gnulib.passthru.longdouble-redirect-patch} ''; strictDeps = true; From 5d64ebd9366a81dc00cd80209cedd05848cf3dcc Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Tue, 26 Jul 2022 14:14:31 -0700 Subject: [PATCH 04/13] texinfo: apply gnulib.passthru.longdouble-redirect-patch Co-authored-by: Sandro --- pkgs/development/tools/misc/texinfo/common.nix | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pkgs/development/tools/misc/texinfo/common.nix b/pkgs/development/tools/misc/texinfo/common.nix index af0d26fe1f3..51df8c555e6 100644 --- a/pkgs/development/tools/misc/texinfo/common.nix +++ b/pkgs/development/tools/misc/texinfo/common.nix @@ -1,6 +1,7 @@ { version, sha256, patches ? [] }: { lib, stdenv, buildPackages, fetchurl, perl, xz, libintl, bash +, gnulib # we are a dependency of gcc, this simplifies bootstraping , interactive ? false, ncurses, procps @@ -30,6 +31,12 @@ stdenv.mkDerivation { postPatch = '' patchShebangs tp/maintain + '' + # This patch is needed for IEEE-standard long doubles on + # powerpc64; it does not apply cleanly to texinfo 5.x or + # earlier. It is merged upstream in texinfo 6.8. + + lib.optionalString (with lib.strings; versionAtLeast version "6.0" && versionOlder version "6.8") '' + patch -p1 -d gnulib < ${gnulib.passthru.longdouble-redirect-patch} ''; # ncurses is required to build `makedoc' @@ -82,6 +89,8 @@ stdenv.mkDerivation { license = licenses.gpl3Plus; platforms = platforms.all; maintainers = with maintainers; [ vrthra oxij ]; + # see comment above in patches section + broken = stdenv.hostPlatform.isPower64 && lib.strings.versionOlder version "6.0"; longDescription = '' Texinfo is the official documentation format of the GNU project. From cee9981b32cddb028bb05738fdea93be13301271 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Wed, 27 Jul 2022 00:10:21 -0700 Subject: [PATCH 05/13] mpfr: add --disable-decimal-float Co-authored-by: Sandro --- pkgs/development/libraries/mpfr/default.nix | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/pkgs/development/libraries/mpfr/default.nix b/pkgs/development/libraries/mpfr/default.nix index e0a33e27c12..aba3a413a66 100644 --- a/pkgs/development/libraries/mpfr/default.nix +++ b/pkgs/development/libraries/mpfr/default.nix @@ -28,9 +28,13 @@ stdenv.mkDerivation rec { # mpfr.h requires gmp.h propagatedBuildInputs = [ gmp ]; - configureFlags = - lib.optional stdenv.hostPlatform.isSunOS "--disable-thread-safe" ++ - lib.optional stdenv.hostPlatform.is64bit "--with-pic"; + configureFlags = lib.optional stdenv.hostPlatform.isSunOS "--disable-thread-safe" + ++ lib.optional stdenv.hostPlatform.is64bit "--with-pic" + ++ lib.optional stdenv.hostPlatform.isPower64 [ + # Without this, the `tget_set_d128` test experiences a link + # error due to missing `__dpd_trunctdkf`. + "--disable-decimal-float" + ]; doCheck = true; # not cross; From e2d44f67370bbb497804efbf9c7bc0bfedd1adcd Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Tue, 26 Jul 2022 01:03:47 -0700 Subject: [PATCH 06/13] libpipeline: apply gnulib.passthru.longdouble-redirect-patch --- .../libraries/libpipeline/default.nix | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/pkgs/development/libraries/libpipeline/default.nix b/pkgs/development/libraries/libpipeline/default.nix index 3630980353a..7cab0816147 100644 --- a/pkgs/development/libraries/libpipeline/default.nix +++ b/pkgs/development/libraries/libpipeline/default.nix @@ -1,4 +1,7 @@ -{ lib, stdenv, fetchurl }: +{ lib, stdenv, fetchurl +, gnulib +, runCommand +, patchutils }: stdenv.mkDerivation rec { pname = "libpipeline"; @@ -9,7 +12,18 @@ stdenv.mkDerivation rec { sha256 = "sha256-uLRRlJiQIqeewTF/ZKKnWxVRsqVb6gb2dwTLKi5GkLA="; }; - patches = lib.optionals stdenv.isDarwin [ ./fix-on-osx.patch ]; + patches = lib.optionals stdenv.isDarwin [ + ./fix-on-osx.patch + ] ++ [ + (runCommand "longdouble-redirect-patch-extraPrefix" {} '' + ${patchutils}/bin/filterdiff \ + --strip=1 \ + --addoldprefix=a/gl/ \ + --addnewprefix=b/gl/ \ + ${gnulib.passthru.longdouble-redirect-patch} \ + > $out + '') + ]; meta = with lib; { homepage = "http://libpipeline.nongnu.org"; From 52cf8fea4fefeb990d72d2159ce42cf7cf94dd2f Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Tue, 26 Jul 2022 01:06:38 -0700 Subject: [PATCH 07/13] libpipeline: 1.5.4 -> 1.5.6 This commit bumps libpipeline and drops the gnulib patch since the vendored copy of gnulib has been updated. I avoided squashing this commit into the previous one since knowing how to patch libpipeline 1.5.4 without upgrading might be useful (for example, in a git bisect or cherry-pick). --- .../libraries/libpipeline/default.nix | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/pkgs/development/libraries/libpipeline/default.nix b/pkgs/development/libraries/libpipeline/default.nix index 7cab0816147..3630980353a 100644 --- a/pkgs/development/libraries/libpipeline/default.nix +++ b/pkgs/development/libraries/libpipeline/default.nix @@ -1,7 +1,4 @@ -{ lib, stdenv, fetchurl -, gnulib -, runCommand -, patchutils }: +{ lib, stdenv, fetchurl }: stdenv.mkDerivation rec { pname = "libpipeline"; @@ -12,18 +9,7 @@ stdenv.mkDerivation rec { sha256 = "sha256-uLRRlJiQIqeewTF/ZKKnWxVRsqVb6gb2dwTLKi5GkLA="; }; - patches = lib.optionals stdenv.isDarwin [ - ./fix-on-osx.patch - ] ++ [ - (runCommand "longdouble-redirect-patch-extraPrefix" {} '' - ${patchutils}/bin/filterdiff \ - --strip=1 \ - --addoldprefix=a/gl/ \ - --addnewprefix=b/gl/ \ - ${gnulib.passthru.longdouble-redirect-patch} \ - > $out - '') - ]; + patches = lib.optionals stdenv.isDarwin [ ./fix-on-osx.patch ]; meta = with lib; { homepage = "http://libpipeline.nongnu.org"; From 40f7300227019403d00965fc37709149ba4eadca Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Mon, 25 Apr 2022 00:00:11 -0700 Subject: [PATCH 08/13] gcc: if isPower64 && !isMusl use --with-long-double-format=ieee Use IEEE-standard floating point on `powerpc64le` instead of IBM-proprietary formats. The GCC wiki has more details on the history here: https://gcc.gnu.org/wiki/Ieee128PowerPC Nixpkgs' stdenv has no legacy `powerpc64le` installs to deal with (stdenv did not bootstrap on powerpc64le until very recenty), so it's much easier decision for us. Red Hat (i.e. IBM) has tried to do this in each of the last *six* releases: https://fedoraproject.org/wiki/Changes/PPC64LE_Float128_Transition they and finally shipped it in May with Fedora 36: https://bugzilla.redhat.com/show_bug.cgi?id=1649936 Apparently glibc 2.35 fixes the last blocker. Co-authored-by: Sandro --- .../compilers/gcc/common/platform-flags.nix | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/pkgs/development/compilers/gcc/common/platform-flags.nix b/pkgs/development/compilers/gcc/common/platform-flags.nix index bd5a72f9603..fc068c194d2 100644 --- a/pkgs/development/compilers/gcc/common/platform-flags.nix +++ b/pkgs/development/compilers/gcc/common/platform-flags.nix @@ -10,7 +10,11 @@ in lib.concatLists [ (lib.optional (p ? fpu) "--with-fpu=${p.fpu}") (lib.optional (p ? float) "--with-float=${p.float}") (lib.optional (p ? mode) "--with-mode=${p.mode}") - (lib.optional - (let tp = targetPlatform; in tp.isPower && tp.libc == "glibc" && tp.is64bit) - "--with-long-double-128") + (lib.optionals targetPlatform.isPower64 + # musl explicitly rejects 128-bit long double on + # powerpc64; see musl/arch/powerpc64/bits/float.h + (lib.optionals (!targetPlatform.isMusl) [ + "--with-long-double-128" + "--with-long-double-format=ieee" + ])) ] From aeae5ca56212e800a86aef237e6500c452fce5a9 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Wed, 27 Jul 2022 10:08:00 -0700 Subject: [PATCH 09/13] Revert "goffice: disable tests on powerpc64le" This reverts commit dd2bc2a721a3c4ba87d10f98425f72c92f5b5033. Co-authored-by: Sandro --- pkgs/development/libraries/goffice/default.nix | 1 - 1 file changed, 1 deletion(-) diff --git a/pkgs/development/libraries/goffice/default.nix b/pkgs/development/libraries/goffice/default.nix index 21713000c64..f7747a26dd6 100644 --- a/pkgs/development/libraries/goffice/default.nix +++ b/pkgs/development/libraries/goffice/default.nix @@ -21,7 +21,6 @@ stdenv.mkDerivation rec { buildInputs = [ libxslt librsvg ]; enableParallelBuilding = true; - doCheck = !stdenv.hostPlatform.isPower64; passthru = { updateScript = gnome.updateScript { From c5a4cc839601e0adafca2eb6cd18858f064e7c06 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Wed, 27 Jul 2022 18:00:53 -0700 Subject: [PATCH 10/13] glibc: suppress warning about IEEE-standard long double --- pkgs/development/libraries/glibc/default.nix | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkgs/development/libraries/glibc/default.nix b/pkgs/development/libraries/glibc/default.nix index 8ad9c90ff7a..1c0c1b09e15 100644 --- a/pkgs/development/libraries/glibc/default.nix +++ b/pkgs/development/libraries/glibc/default.nix @@ -63,6 +63,13 @@ in # Same for musl: https://github.com/NixOS/nixpkgs/issues/78805 "-Wno-error=missing-attributes" ]) + (lib.optionals (stdenv.hostPlatform.isPower64) [ + # Do not complain about the Processor Specific ABI (i.e. the + # choice to use IEEE-standard `long double`). We pass this + # flag in order to mute a `-Werror=psabi` passed by glibc; + # hopefully future glibc releases will not pass that flag. + "-Wno-error=psabi" + ]) ]); }; From 29b395309fbd55626087ed60e319aa86e5b70264 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Mon, 8 Aug 2022 03:51:28 -0700 Subject: [PATCH 11/13] gcc: make --with-long-double-format configurable by targetPlatform.gcc --- pkgs/development/compilers/gcc/common/platform-flags.nix | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkgs/development/compilers/gcc/common/platform-flags.nix b/pkgs/development/compilers/gcc/common/platform-flags.nix index fc068c194d2..111af8ed430 100644 --- a/pkgs/development/compilers/gcc/common/platform-flags.nix +++ b/pkgs/development/compilers/gcc/common/platform-flags.nix @@ -1,7 +1,8 @@ { lib, targetPlatform }: let - p = targetPlatform.gcc or {} + gcc = targetPlatform.gcc or {}; + p = gcc // targetPlatform.parsed.abi; in lib.concatLists [ (lib.optional (!targetPlatform.isx86_64 && p ? arch) "--with-arch=${p.arch}") # --with-arch= is unknown flag on x86_64 @@ -15,6 +16,6 @@ in lib.concatLists [ # powerpc64; see musl/arch/powerpc64/bits/float.h (lib.optionals (!targetPlatform.isMusl) [ "--with-long-double-128" - "--with-long-double-format=ieee" + "--with-long-double-format=${gcc.long-double-format or "ieee"}" ])) ] From deda18bae8a38ec76c9366e227e3a2b8610ad697 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Mon, 8 Aug 2022 04:09:33 -0700 Subject: [PATCH 12/13] gcc: only pass --with-long-double-format if gcc allows it --- pkgs/development/compilers/gcc/common/platform-flags.nix | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pkgs/development/compilers/gcc/common/platform-flags.nix b/pkgs/development/compilers/gcc/common/platform-flags.nix index 111af8ed430..c0593cd781e 100644 --- a/pkgs/development/compilers/gcc/common/platform-flags.nix +++ b/pkgs/development/compilers/gcc/common/platform-flags.nix @@ -14,7 +14,14 @@ in lib.concatLists [ (lib.optionals targetPlatform.isPower64 # musl explicitly rejects 128-bit long double on # powerpc64; see musl/arch/powerpc64/bits/float.h - (lib.optionals (!targetPlatform.isMusl) [ + (lib.optionals + (!targetPlatform.isMusl + && (targetPlatform.isLittleEndian || + # "... --with-long-double-format is only supported if the default cpu is power7 or newer" + # https://github.com/NixOS/nixpkgs/pull/170215#issuecomment-1202164709 + (lib.lists.elem + (lib.strings.substring 0 6 (p.cpu or "")) + [ "power7" "power8" "power9" "power1"/*0, 11, etc*/ ]))) [ "--with-long-double-128" "--with-long-double-format=${gcc.long-double-format or "ieee"}" ])) From 0ce0096e8f6c01c554b072144aa30af1e74bfbb3 Mon Sep 17 00:00:00 2001 From: Adam Joseph Date: Mon, 2 Jan 2023 01:06:49 -0800 Subject: [PATCH 13/13] drop gnused gnulib.passthru.longdouble-redirect-patch This reverts commit d455973ece7f51907e86fa4e69947ae0eca6bfa1. --- pkgs/tools/text/gnused/default.nix | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/pkgs/tools/text/gnused/default.nix b/pkgs/tools/text/gnused/default.nix index 35e707acaf9..f493e4f358d 100644 --- a/pkgs/tools/text/gnused/default.nix +++ b/pkgs/tools/text/gnused/default.nix @@ -1,5 +1,4 @@ -{ lib, stdenv, fetchurl, perl -, gnulib }: +{ lib, stdenv, fetchurl, perl }: stdenv.mkDerivation rec { pname = "gnused"; @@ -13,13 +12,6 @@ stdenv.mkDerivation rec { outputs = [ "out" "info" ]; nativeBuildInputs = [ perl ]; - - patches = [ - # this change to gnused's vendored copy of gnulib is already - # merged upstream; we can drop this patch on the next version bump - gnulib.passthru.longdouble-redirect-patch - ]; - preConfigure = "patchShebangs ./build-aux/help2man"; # Prevents attempts of running 'help2man' on cross-built binaries.