From a0c9b8b4fae3e56c1ed7ae6a45d5a3979aca763b Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Sat, 11 Jun 2022 14:45:53 +0100 Subject: [PATCH] gnome.nautilus-python: add -fcommon workaround Workaround build failure on -fno-common toolchains like upstream gcc-10. Otherwise build fails as: ld: nautilus-python-object.o:src/nautilus-python.h:61: multiple definition of `_PyNautilusMenu_Type'; nautilus-python.o:src/nautilus-python.h:61: first defined here --- pkgs/desktops/gnome/misc/nautilus-python/default.nix | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkgs/desktops/gnome/misc/nautilus-python/default.nix b/pkgs/desktops/gnome/misc/nautilus-python/default.nix index ed1fd365ebc..c1d58e2dbda 100644 --- a/pkgs/desktops/gnome/misc/nautilus-python/default.nix +++ b/pkgs/desktops/gnome/misc/nautilus-python/default.nix @@ -51,6 +51,13 @@ stdenv.mkDerivation rec { gtk3 # required by libnautilus-extension ]; + # Workaround build failure on -fno-common toolchains: + # ld: nautilus-python-object.o:src/nautilus-python.h:61: multiple definition of + # `_PyNautilusMenu_Type'; nautilus-python.o:src/nautilus-python.h:61: first defined here + # TODO: remove it once upstream fixes and releases: + # https://gitlab.gnome.org/GNOME/nautilus-python/-/merge_requests/7 + NIX_CFLAGS_COMPILE = "-fcommon"; + makeFlags = [ "PYTHON_LIB_LOC=${python3}/lib" ];