From 6c8f82937fb433065945faa545883714677a7b4e Mon Sep 17 00:00:00 2001 From: colin Date: Tue, 1 Nov 2022 22:12:29 -0700 Subject: [PATCH] librewolf: build with `MOZ_REQUIRE_SIGNING = ""` this allows sideloading unsigned browser extensions (via the `nixExtensions` option in the [firefox-wrapper]). i believe librewolf is meant to allow unsigned sideloading, based on upstream discussions and this bit that already exists in ./librewolf.nix: ```nix extraConfigureFlags = [ "--with-unsigned-addon-scopes=app,system" "--allow-addon-sideload" ]; ``` but Mozilla changed some defaults over the years. this `MOZ_REQUIRE_SIGNING` option is mentioned [upstream] and we can see that the arch [[pkgbuild]] clears it in a similar manner. [upstream]: https://gitlab.com/librewolf-community/browser/arch/-/issues/49 [pkgbuild]: https://gitlab.com/librewolf-community/browser/arch/-/blob/master/PKGBUILD#L95 [firefox-wrapper]: pkgs/applications/networking/browsers/firefox/wrapper.nix --- pkgs/applications/networking/browsers/librewolf/default.nix | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/networking/browsers/librewolf/default.nix b/pkgs/applications/networking/browsers/librewolf/default.nix index 6e81450b22d..b4068d5acfc 100644 --- a/pkgs/applications/networking/browsers/librewolf/default.nix +++ b/pkgs/applications/networking/browsers/librewolf/default.nix @@ -3,7 +3,7 @@ let librewolf-src = callPackage ./librewolf.nix { }; in -(buildMozillaMach rec { +((buildMozillaMach rec { pname = "librewolf"; applicationName = "LibreWolf"; binaryName = "librewolf"; @@ -30,4 +30,6 @@ in crashreporterSupport = false; enableOfficialBranding = false; pgoSupport = false; # Profiling gets stuck and doesn't terminate. -} +}).overrideAttrs (prev: { + MOZ_REQUIRE_SIGNING = ""; +})