From d1aa187c0e1fa3a91d1204b810794cc0f1d17842 Mon Sep 17 00:00:00 2001 From: pennae Date: Wed, 18 Jan 2023 01:04:21 +0100 Subject: [PATCH] nixos/make-options-doc: don't escape link urls twice mistune already does escaping. it does escaping for html, but the difference is small enough that can just ignore that we're actually targeting docbook here. --- nixos/lib/make-options-doc/mergeJSON.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/nixos/lib/make-options-doc/mergeJSON.py b/nixos/lib/make-options-doc/mergeJSON.py index c27cd9d3c6d..db14808e84e 100644 --- a/nixos/lib/make-options-doc/mergeJSON.py +++ b/nixos/lib/make-options-doc/mergeJSON.py @@ -80,15 +80,14 @@ class Renderer(mistune.renderers.BaseRenderer): if text == "": tag = "xref" attr = "linkend" - link = quoteattr(link[1:]) + link = link[1:] else: # try to faithfully reproduce links that were of the form # in docbook format if text == link: text = "" attr = "xlink:href" - link = quoteattr(link) - return f"<{tag} {attr}={link}>{text}" + return f"<{tag} {attr}=\"{link}\">{text}" def list(self, text, ordered, level, start=None): if ordered: raise NotImplementedError("ordered lists not supported yet")