From de5a39f5e7d8ed4d9914e6e41de0834351ad3142 Mon Sep 17 00:00:00 2001 From: Silvan Mosberger Date: Mon, 14 Aug 2023 19:03:56 +0200 Subject: [PATCH] CONTRIBUTING.md: Move boot loader-specific sentence to pkgs/README.md This needs a rewrite at some point.. --- CONTRIBUTING.md | 2 -- nixos/README.md | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2154271a641..bb666850ae8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -506,8 +506,6 @@ To get a sense for what changes are considered mass rebuilds, see [previously me ## Commit conventions [commit-conventions]: #commit-conventions -- When changing the bootloader installation process, extra care must be taken. Grub installations cannot be rolled back, hence changes may break people’s installations forever. For any non-trivial change to the bootloader please file a PR asking for review, especially from \@edolstra. - - Create a commit for each logical unit. - Check for unnecessary whitespace with `git diff --check` before committing. diff --git a/nixos/README.md b/nixos/README.md index 7f66a132fb9..b3cd9d234fa 100644 --- a/nixos/README.md +++ b/nixos/README.md @@ -10,6 +10,8 @@ You can add new module to your NixOS configuration file (usually it’s `/etc/ni ## Reviewing contributions +When changing the bootloader installation process, extra care must be taken. Grub installations cannot be rolled back, hence changes may break people’s installations forever. For any non-trivial change to the bootloader please file a PR asking for review, especially from \@edolstra. + ### Module updates Module updates are submissions changing modules in some ways. These often contains changes to the options or introduce new options.