From 95c3946692836205b2a5d26f6d06a6f1611034d4 Mon Sep 17 00:00:00 2001 From: Austin Horstman Date: Sun, 30 Jul 2023 21:29:37 -0500 Subject: [PATCH 1/3] skhd: add khaneliman as maintainer --- pkgs/os-specific/darwin/skhd/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/os-specific/darwin/skhd/default.nix b/pkgs/os-specific/darwin/skhd/default.nix index ad33cf713d0..bfd1e5d8047 100644 --- a/pkgs/os-specific/darwin/skhd/default.nix +++ b/pkgs/os-specific/darwin/skhd/default.nix @@ -25,7 +25,7 @@ stdenv.mkDerivation rec { description = "Simple hotkey daemon for macOS"; homepage = "https://github.com/koekeishiya/skhd"; platforms = platforms.darwin; - maintainers = with maintainers; [ cmacrae lnl7 periklis ]; + maintainers = with maintainers; [ cmacrae lnl7 periklis khaneliman]; license = licenses.mit; }; } From a8b5053805b3a9734000c20475d5eeb2eafb0fd1 Mon Sep 17 00:00:00 2001 From: Austin Horstman Date: Sun, 30 Jul 2023 21:36:19 -0500 Subject: [PATCH 2/3] skhd: 0.3.5 -> 0.3.9 --- pkgs/os-specific/darwin/skhd/default.nix | 8 ++++---- pkgs/top-level/all-packages.nix | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkgs/os-specific/darwin/skhd/default.nix b/pkgs/os-specific/darwin/skhd/default.nix index bfd1e5d8047..05142d11f36 100644 --- a/pkgs/os-specific/darwin/skhd/default.nix +++ b/pkgs/os-specific/darwin/skhd/default.nix @@ -1,17 +1,17 @@ -{ lib, stdenv, fetchFromGitHub, Carbon }: +{ lib, stdenv, fetchFromGitHub, Carbon, Cocoa }: stdenv.mkDerivation rec { pname = "skhd"; - version = "0.3.5"; + version = "0.3.9"; src = fetchFromGitHub { owner = "koekeishiya"; repo = pname; rev = "v${version}"; - sha256 = "0x099979kgpim18r0vi9vd821qnv0rl3rkj0nd1nx3wljxgf7mrg"; + sha256 = "fnkWws/g4BdHKDRhqoCpdPFUavOHdk8R7h7H1dAdAYI="; }; - buildInputs = [ Carbon ]; + buildInputs = [ Carbon Cocoa ]; makeFlags = [ "BUILD_PATH=$(out)/bin" ]; diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 877a88a0ff1..3d30a03dfa3 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -3940,8 +3940,8 @@ with pkgs; reattach-to-user-namespace = callPackage ../os-specific/darwin/reattach-to-user-namespace { }; - skhd = callPackage ../os-specific/darwin/skhd { - inherit (darwin.apple_sdk.frameworks) Carbon; + skhd = darwin.apple_sdk_11_0.callPackage ../os-specific/darwin/skhd { + inherit (darwin.apple_sdk_11_0.frameworks) Carbon Cocoa; }; qes = callPackage ../os-specific/darwin/qes { From 684f3c72b469c359dc5057c2468c4ebc5971c138 Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Mon, 31 Jul 2023 09:37:07 +0200 Subject: [PATCH 3/3] skhd: use `finalAttrs` pattern --- pkgs/os-specific/darwin/skhd/default.nix | 34 +++++++++++++++--------- 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/pkgs/os-specific/darwin/skhd/default.nix b/pkgs/os-specific/darwin/skhd/default.nix index 05142d11f36..2de0a8d4d51 100644 --- a/pkgs/os-specific/darwin/skhd/default.nix +++ b/pkgs/os-specific/darwin/skhd/default.nix @@ -1,19 +1,29 @@ -{ lib, stdenv, fetchFromGitHub, Carbon, Cocoa }: +{ lib +, stdenv +, fetchFromGitHub +, Carbon +, Cocoa +}: -stdenv.mkDerivation rec { +stdenv.mkDerivation (finalAttrs: { pname = "skhd"; version = "0.3.9"; src = fetchFromGitHub { owner = "koekeishiya"; - repo = pname; - rev = "v${version}"; - sha256 = "fnkWws/g4BdHKDRhqoCpdPFUavOHdk8R7h7H1dAdAYI="; + repo = "skhd"; + rev = "v${finalAttrs.version}"; + hash = "sha256-fnkWws/g4BdHKDRhqoCpdPFUavOHdk8R7h7H1dAdAYI="; }; - buildInputs = [ Carbon Cocoa ]; + buildInputs = [ + Carbon + Cocoa + ]; - makeFlags = [ "BUILD_PATH=$(out)/bin" ]; + makeFlags = [ + "BUILD_PATH=$(out)/bin" + ]; postInstall = '' mkdir -p $out/Library/LaunchDaemons @@ -21,11 +31,11 @@ stdenv.mkDerivation rec { substituteInPlace $out/Library/LaunchDaemons/org.nixos.skhd.plist --subst-var out ''; - meta = with lib; { + meta = { description = "Simple hotkey daemon for macOS"; homepage = "https://github.com/koekeishiya/skhd"; - platforms = platforms.darwin; - maintainers = with maintainers; [ cmacrae lnl7 periklis khaneliman]; - license = licenses.mit; + license = lib.licenses.mit; + maintainers = with lib.maintainers; [ cmacrae lnl7 periklis khaneliman]; + platforms = lib.platforms.darwin; }; -} +})