From e82d62cac2b9dfa3dc34e3333ddd7f0165fd1ad3 Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Sun, 29 May 2022 22:09:46 +0100 Subject: [PATCH] tftp-hpa: add -fcommon workaround Workaround build failure on -fno-common toolchains like upstream gcc-10. Otherwise build fails as: ld: main.o:/build/tftp-hpa-5.2/tftp/main.c:98: multiple definition of `toplevel'; tftp.o:/build/tftp-hpa-5.2/tftp/tftp.c:51: first defined here --- pkgs/tools/networking/tftp-hpa/default.nix | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkgs/tools/networking/tftp-hpa/default.nix b/pkgs/tools/networking/tftp-hpa/default.nix index f8e028dc616..987315b8351 100644 --- a/pkgs/tools/networking/tftp-hpa/default.nix +++ b/pkgs/tools/networking/tftp-hpa/default.nix @@ -8,6 +8,12 @@ stdenv.mkDerivation rec { sha256 = "12vidchglhyc20znq5wdsbhi9mqg90jnl7qr9qs8hbvaz4fkdvmg"; }; + # Workaround build failure on -fno-common toolchains like upstream + # gcc-10. Otherwise build fails as: + # ld: main.o:/build/tftp-hpa-5.2/tftp/main.c:98: multiple definition of + # `toplevel'; tftp.o:/build/tftp-hpa-5.2/tftp/tftp.c:51: first defined here + NIX_CFLAGS_COMPILE="-fcommon"; + meta = with lib; { description = "TFTP tools - a lot of fixes on top of BSD TFTP"; maintainers = with maintainers; [ raskin ];