python3Packages.tensorboardx: fix build

Adds missing optional soundfile dependency, that was ultimately
required during tests.

Move crc32 into propagatedBuildInputs.

Both changes were recommended here:
https://github.com/lanpa/tensorboardX/blob/v2.1/README.md#install

Clean up the package, disable linting tests.
This commit is contained in:
Martin Weinelt 2021-04-15 02:04:25 +02:00
parent a812d1b7af
commit f29e513834

View file

@ -1,6 +1,20 @@
{ boto3, buildPythonPackage, crc32c, fetchFromGitHub, lib, matplotlib, moto
, numpy, pillow, pytorch, protobuf, six, pytestCheckHook
, tensorflow-tensorboard, torchvision }:
{ boto3
, buildPythonPackage
, crc32c
, fetchFromGitHub
, lib
, matplotlib
, moto
, numpy
, pillow
, protobuf
, pytestCheckHook
, pytorch
, six
, soundfile
, tensorflow-tensorboard
, torchvision
}:
buildPythonPackage rec {
pname = "tensorboardx";
@ -13,19 +27,43 @@ buildPythonPackage rec {
sha256 = "1palz91y0b39pcmwg6wdmqfal38hai99dd6r88i3imqxdbmjghih";
};
checkInputs = [
pytestCheckHook boto3 crc32c matplotlib moto pillow pytorch tensorflow-tensorboard torchvision
];
propagatedBuildInputs = [ numpy protobuf six ];
# apparently torch API changed a bit at 1.6
postPatch = ''
substituteInPlace tensorboardX/pytorch_graph.py --replace "torch.onnx.set_training(model, False)" "torch.onnx.select_model_mode_for_export(model, torch.onnx.TrainingMode.EVAL)"
substituteInPlace tensorboardX/pytorch_graph.py --replace \
"torch.onnx.set_training(model, False)" \
"torch.onnx.select_model_mode_for_export(model, torch.onnx.TrainingMode.EVAL)"
'';
propagatedBuildInputs = [
crc32c
numpy
protobuf
six
soundfile
];
disabledTests = [ "test_TorchVis" "test_onnx_graph" ];
checkInputs = [
boto3
matplotlib
moto
pillow
pytestCheckHook
pytorch
tensorflow-tensorboard
torchvision
];
disabledTests = [
# ImportError: Visdom visualization requires installation of Visdom
"test_TorchVis"
# Requires network access (FileNotFoundError: [Errno 2] No such file or directory: 'wget')
"test_onnx_graph"
];
disabledTestPaths = [
# we are not interested in linting errors
"tests/test_lint.py"
];
meta = with lib; {
description = "Library for writing tensorboard-compatible logs";