korbs/electron-tabs
1
0
Fork 0
mirror of https://ark.sudovanilla.org/Korbs/electron-tabs.git synced 2024-12-23 03:53:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #27 from ChenYuHo/master

Browse source 
fix issue #15 add duplicate tab when addTab with {active:true}
This commit is contained in:
Thomas Brouard 2017-06-14 18:29:08 +02:00 committed by GitHub
parent 869fd7e45b 7f91ffc5bd
commit bb1262473d
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
index.js
View file

@ -59,6 +59,10 @@ class TabGroup extends EventEmitter {
this.newTabId++; this.newTabId++;
let tab = new Tab(this, id, args); let tab = new Tab(this, id, args);
this.tabs.push(tab); this.tabs.push(tab);
// Don't call tab.activate() before a tab is referenced in this.tabs
if (args.active === true) {
tab.activate();
}
this.emit("tab-added", tab, this); this.emit("tab-added", tab, this);
return tab; return tab;
} }
@ -134,9 +138,6 @@ class Tab extends EventEmitter {
if (args.visible !== false) { if (args.visible !== false) {
this.show(); this.show();
} }
if (args.active === true) {
this.activate();
}
if (typeof args.ready === "function") { if (typeof args.ready === "function") {
args.ready(this); args.ready(this);
} }