Make consistant API for flash and show

This commit is contained in:
Thomas Brouard 2016-11-01 16:05:09 +01:00
parent e7f8111e03
commit f6664f50d3

View file

@ -182,30 +182,38 @@ class Tab extends EventEmitter {
return this; return this;
} }
show () { show (flag) {
if (this.isClosed) return; if (this.isClosed) return;
if (flag !== false) {
this.tab.classList.add("visible"); this.tab.classList.add("visible");
this.emit("visible", this);
} else {
this.tab.classList.remove("visible");
this.emit("hidden", this);
}
return this; return this;
} }
hide () { hide () {
if (this.isClosed) return; return this.show(false);
this.tab.classList.remove("visible");
return this;
} }
flash (flag) { flash (flag) {
if (this.isClosed) return; if (this.isClosed) return;
if (flag !== false) { if (flag !== false) {
this.tab.classList.add("flash"); this.tab.classList.add("flash");
this.emit("flash-start", this); this.emit("flash", this);
} else { } else {
this.tab.classList.remove("flash"); this.tab.classList.remove("flash");
this.emit("flash-end", this); this.emit("unflash", this);
} }
return this; return this;
} }
unflash () {
return this.flash(false);
}
close (force) { close (force) {
if (this.isClosed || (!this.closable && !force)) return; if (this.isClosed || (!this.closable && !force)) return;
this.isClosed = true; this.isClosed = true;