pub-solar/forgejo
5
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix tooltip init after review (#20814)

Browse source 
* Fix tooltip init after review

Previous code passed a jQuery collection which initTooltip couldn't
handle. Instead, iterate the individial matched elements and add a
dollar to the variable name to make it clear it's jQuery.

Fixes: https://github.com/go-gitea/gitea/issues/20809
This commit is contained in:
silverwind 2022-08-16 23:05:40 +02:00 committed by GitHub
parent 82f89ff996
commit 1e0fcd1450
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
web_src/js/features/repo-diff.js
View file

@ -44,24 +44,28 @@ export function initRepoDiffConversationForm() {
$(document).on('submit', '.conversation-holder form', async (e) => { $(document).on('submit', '.conversation-holder form', async (e) => {
e.preventDefault(); e.preventDefault();
const form = $(e.target); const $form = $(e.target);
const $textArea = form.find('textarea'); const $textArea = $form.find('textarea');
if (!validateTextareaNonEmpty($textArea)) { if (!validateTextareaNonEmpty($textArea)) {
return; return;
} }
const newConversationHolder = $(await $.post(form.attr('action'), form.serialize())); const formDataString = String(new URLSearchParams(new FormData($form[0])));
const {path, side, idx} = newConversationHolder.data(); const $newConversationHolder = $(await $.post($form.attr('action'), formDataString));
const {path, side, idx} = $newConversationHolder.data();
initTooltip(newConversationHolder.find('.tooltip')); $newConversationHolder.find('.tooltip').each(function () {
form.closest('.conversation-holder').replaceWith(newConversationHolder); initTooltip(this);
if (form.closest('tr').data('line-type') === 'same') { });
$form.closest('.conversation-holder').replaceWith($newConversationHolder);
if ($form.closest('tr').data('line-type') === 'same') {
$(`[data-path="${path}"] a.add-code-comment[data-idx="${idx}"]`).addClass('invisible'); $(`[data-path="${path}"] a.add-code-comment[data-idx="${idx}"]`).addClass('invisible');
} else { } else {
$(`[data-path="${path}"] a.add-code-comment[data-side="${side}"][data-idx="${idx}"]`).addClass('invisible'); $(`[data-path="${path}"] a.add-code-comment[data-side="${side}"][data-idx="${idx}"]`).addClass('invisible');
} }
newConversationHolder.find('.dropdown').dropdown(); $newConversationHolder.find('.dropdown').dropdown();
initCompReactionSelector(newConversationHolder); initCompReactionSelector($newConversationHolder);
}); });