pub-solar/forgejo
5
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Remove jQuery from the create/rename branch modals (except Fomantic) (#30109)

Browse source 
- Switched to plain JavaScript
- Tested the create/rename branch modals' functionality and they work as
before

# Demo using JavaScript without jQuery

![demo](https://github.com/go-gitea/gitea/assets/20454870/ca53155e-856e-44ca-9852-12ff60065735)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit 4efe7884a3c99235b39998472ea430bffe0799e5)
This commit is contained in:
Yarden Shoham 2024-03-27 12:40:21 +02:00 committed by Earl Warren
parent 8bc4c1c9b0
commit 4249512c73
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
1 changed files with 25 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
web_src/js/features/repo-branch.js
View file

@ -8,35 +8,35 @@ export function initRepoBranchButton() {
function initRepoCreateBranchButton() { function initRepoCreateBranchButton() {
// 2 pages share this code, one is the branch list page, the other is the commit view page: create branch/tag from current commit (dirty code) // 2 pages share this code, one is the branch list page, the other is the commit view page: create branch/tag from current commit (dirty code)
$('.show-create-branch-modal').on('click', function () { for (const el of document.querySelectorAll('.show-create-branch-modal')) {
let modalFormName = $(this).attr('data-modal-form'); el.addEventListener('click', () => {
if (!modalFormName) { const modalFormName = el.getAttribute('data-modal-form') || '#create-branch-form';
modalFormName = '#create-branch-form'; const modalForm = document.querySelector(modalFormName);
} if (!modalForm) return;
$(modalFormName)[0].action = $(modalFormName).attr('data-base-action') + $(this).attr('data-branch-from-urlcomponent'); modalForm.action = `${modalForm.getAttribute('data-base-action')}${el.getAttribute('data-branch-from-urlcomponent')}`;
let fromSpanName = $(this).attr('data-modal-from-span');
if (!fromSpanName) {
fromSpanName = '#modal-create-branch-from-span';
}
$(fromSpanName).text($(this).attr('data-branch-from')); const fromSpanName = el.getAttribute('data-modal-from-span') || '#modal-create-branch-from-span';
$($(this).attr('data-modal')).modal('show'); document.querySelector(fromSpanName).textContent = el.getAttribute('data-branch-from');
});
$(el.getAttribute('data-modal')).modal('show');
});
}
} }
function initRepoRenameBranchButton() { function initRepoRenameBranchButton() {
$('.show-rename-branch-modal').on('click', function () { for (const el of document.querySelectorAll('.show-rename-branch-modal')) {
const target = $(this).attr('data-modal'); el.addEventListener('click', () => {
const $modal = $(target); const target = el.getAttribute('data-modal');
const modal = document.querySelector(target);
const oldBranchName = el.getAttribute('data-old-branch-name');
modal.querySelector('input[name=from]').value = oldBranchName;
const oldBranchName = $(this).attr('data-old-branch-name'); // display the warning that the branch which is chosen is the default branch
$modal.find('input[name=from]').val(oldBranchName); const warn = modal.querySelector('.default-branch-warning');
toggleElem(warn, el.getAttribute('data-is-default-branch') === 'true');
// display the warning that the branch which is chosen is the default branch const text = modal.querySelector('[data-rename-branch-to]');
const $warn = $modal.find('.default-branch-warning'); text.textContent = text.getAttribute('data-rename-branch-to').replace('%s', oldBranchName);
toggleElem($warn, $(this).attr('data-is-default-branch') === 'true'); });
}
const $text = $modal.find('[data-rename-branch-to]');
$text.text($text.attr('data-rename-branch-to').replace('%s', oldBranchName));
});
} }