pub-solar/forgejo
5
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix bug of migrate comments which only fetch one page (#17055)

Browse source 
* Fix bug of migrate comments which only fetch one page

* add next page to trace

Co-authored-by: zeripath <art27@cantab.net>
This commit is contained in:
Lunny Xiao 2021-09-15 19:30:19 +08:00 committed by GitHub
parent db6b7db06d
commit 45ebcb0d1c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
modules/migrations/github.go
View file

@ -521,6 +521,9 @@ func (g *GithubDownloaderV3) GetAllComments(page, perPage int) ([]*base.Comment,
created = "created" created = "created"
asc = "asc" asc = "asc"
) )
if perPage > g.maxPerPage {
perPage = g.maxPerPage
}
opt := &github.IssueListCommentsOptions{ opt := &github.IssueListCommentsOptions{
Sort: &created, Sort: &created,
Direction: &asc, Direction: &asc,
@ -535,7 +538,9 @@ func (g *GithubDownloaderV3) GetAllComments(page, perPage int) ([]*base.Comment,
if err != nil { if err != nil {
return nil, false, fmt.Errorf("error while listing repos: %v", err) return nil, false, fmt.Errorf("error while listing repos: %v", err)
} }
log.Trace("Request get comments %d/%d, but in fact get %d", perPage, page, len(comments)) var isEnd = resp.NextPage == 0
log.Trace("Request get comments %d/%d, but in fact get %d, next page is %d", perPage, page, len(comments), resp.NextPage)
g.rate = &resp.Rate g.rate = &resp.Rate
for _, comment := range comments { for _, comment := range comments {
// get reactions // get reactions
@ -575,7 +580,7 @@ func (g *GithubDownloaderV3) GetAllComments(page, perPage int) ([]*base.Comment,
}) })
} }
return allComments, len(allComments) < perPage, nil return allComments, isEnd, nil
} }
// GetPullRequests returns pull requests according page and perPage // GetPullRequests returns pull requests according page and perPage