From 55801cf4eb9daeae43c828e54cd94ad841578cb6 Mon Sep 17 00:00:00 2001
From: zeripath <art27@cantab.net>
Date: Thu, 29 Oct 2020 12:48:07 +0000
Subject: [PATCH] Issue comment reactions should also check pull type (#13349)
* Migrating reactions is just not that important
A failure during migrating reactions should not cause failure of
migration.
Signed-off-by: Andrew Thornton <art27@cantab.net>
* When checking issue reactions check the correct permission
Signed-off-by: Andrew Thornton <art27@cantab.net>
* And there is another one ...
Signed-off-by: Andrew Thornton <art27@cantab.net>
---
routers/api/v1/repo/issue_reaction.go | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/routers/api/v1/repo/issue_reaction.go b/routers/api/v1/repo/issue_reaction.go
index 5c983b0fc..dfe618480 100644
--- a/routers/api/v1/repo/issue_reaction.go
+++ b/routers/api/v1/repo/issue_reaction.go
@@ -57,7 +57,11 @@ func GetIssueCommentReactions(ctx *context.APIContext) {
return
}
- if !ctx.Repo.CanRead(models.UnitTypeIssues) {
+ if err := comment.LoadIssue(); err != nil {
+ ctx.Error(http.StatusInternalServerError, "comment.LoadIssue", err)
+ }
+
+ if !ctx.Repo.CanReadIssuesOrPulls(comment.Issue.IsPull) {
ctx.Error(http.StatusForbidden, "GetIssueCommentReactions", errors.New("no permission to get reactions"))
return
}