pub-solar/forgejo
5
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Use "small-loading-icon" insead of "btn-octicon is-loading" (#26710)

Browse source 
The "btn-octicon is-loading" was introduced by #21842 , it is only used
by the "Copy Content" button, but the "btn-octicon" selector would
affect too many uncertain elements.

Now there is a general "small-loading-icon" class, so the "btn-octicon
is-loading" could be removed.
This commit is contained in:
wxiaoguang 2023-08-24 22:21:41 +08:00 committed by GitHub
parent 09faf43ef8
commit 8ac83043f5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
web_src/css/modules/animations.css
View file

@ -57,13 +57,6 @@ form.single-button-form.is-loading .button {
background: transparent; background: transparent;
} }
/* TODO: not needed, use "is-loading small-loading-icon" instead */
.btn-octicon.is-loading::after {
border-width: 2px;
height: 1.25rem;
width: 1.25rem;
}
/* TODO: not needed, use "is-loading small-loading-icon" instead */ /* TODO: not needed, use "is-loading small-loading-icon" instead */
code.language-math.is-loading::after { code.language-math.is-loading::after {
padding: 0; padding: 0;

4
web_src/js/features/copycontent.js
View file

@ -18,7 +18,7 @@ export function initCopyContent() {
// the text to copy is not in the DOM or it is an image which should be // the text to copy is not in the DOM or it is an image which should be
// fetched to copy in full resolution // fetched to copy in full resolution
if (link) { if (link) {
btn.classList.add('is-loading'); btn.classList.add('is-loading', 'small-loading-icon');
try { try {
const res = await fetch(link, {credentials: 'include', redirect: 'follow'}); const res = await fetch(link, {credentials: 'include', redirect: 'follow'});
const contentType = res.headers.get('content-type'); const contentType = res.headers.get('content-type');
@ -32,7 +32,7 @@ export function initCopyContent() {
} catch { } catch {
return showTemporaryTooltip(btn, i18n.copy_error); return showTemporaryTooltip(btn, i18n.copy_error);
} finally { } finally {
btn.classList.remove('is-loading'); btn.classList.remove('is-loading', 'small-loading-icon');
} }
} else { // text, read from DOM } else { // text, read from DOM
const lineEls = document.querySelectorAll('.file-view .lines-code'); const lineEls = document.querySelectorAll('.file-view .lines-code');