From b8253607fea3a20d371ec1f6a30133e0ad72a2be Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Sun, 25 Jun 2023 10:03:09 +0800 Subject: [PATCH] Revert "Make buttons in a modal form have proper type. (#25446)" (#25485) There is a side effect because some modal doesn't have a proper "ok" button. This reverts commit a954c93a68072042aa7dad717b6fa002c83a58fb. --- web_src/js/features/common-global.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/web_src/js/features/common-global.js b/web_src/js/features/common-global.js index 8bbf202ef..e5fd7c29f 100644 --- a/web_src/js/features/common-global.js +++ b/web_src/js/features/common-global.js @@ -395,8 +395,6 @@ function initGlobalShowModal() { if (colorPickers.length > 0) { initCompColorPicker(); // FIXME: this might cause duplicate init } - // all non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter" - $modal.find('form button:not(.ok):not([type])').attr('type', 'button'); $modal.modal('setting', { onApprove: () => { // "form-fetch-action" can handle network errors gracefully,