pub-solar/forgejo
5
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

actions artifacts: warn instead of error on invalid request

Browse source
This commit is contained in:
oliverpool 2024-03-19 16:00:48 +01:00
parent a0d1cfdf7d
commit e7abda6a0d
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
routers/api/actions/artifacts.go
View file

@ -311,7 +311,7 @@ func (ar artifactRoutes) comfirmUploadArtifact(ctx *ArtifactContext) {
} }
artifactName := ctx.Req.URL.Query().Get("artifactName") artifactName := ctx.Req.URL.Query().Get("artifactName")
if artifactName == "" { if artifactName == "" {
log.Error("Error artifact name is empty") log.Warn("Error artifact name is empty")
ctx.Error(http.StatusBadRequest, "Error artifact name is empty") ctx.Error(http.StatusBadRequest, "Error artifact name is empty")
return return
} }

2
routers/api/actions/artifacts_utils.go
View file

@ -61,7 +61,7 @@ func validateArtifactHash(ctx *ArtifactContext, artifactName string) bool {
if paramHash == artifactHash { if paramHash == artifactHash {
return true return true
} }
log.Error("Invalid artifact hash: %s", paramHash) log.Warn("Invalid artifact hash: %s", paramHash)
ctx.Error(http.StatusBadRequest, "Invalid artifact hash") ctx.Error(http.StatusBadRequest, "Invalid artifact hash")
return false return false
} }

2
routers/api/actions/artifactsv4.go
View file

@ -359,7 +359,7 @@ func (r *artifactV4Routes) finalizeArtifact(ctx *ArtifactContext) {
checksum = req.Hash.Value checksum = req.Hash.Value
} }
if err := mergeChunksForArtifact(ctx, chunks, r.fs, artifact, checksum); err != nil { if err := mergeChunksForArtifact(ctx, chunks, r.fs, artifact, checksum); err != nil {
log.Error("Error merge chunks: %v", err) log.Warn("Error merge chunks: %v", err)
ctx.Error(http.StatusInternalServerError, "Error merge chunks") ctx.Error(http.StatusInternalServerError, "Error merge chunks")
return return
} }