pub-solar/infra
6
1
Fork 3
Code Issues 16 Pull requests 7 Actions Packages Projects 1 Releases Wiki Activity

feat(matrix-synapse): enable metrics #100

Merged
teutat3s merged 4 commits from feat/synapse-metrics into main 2024-01-28 23:56:42 +00:00
Conversation 0 Commits 4 Files changed 5 +89 -9
teutat3s commented 2024-01-25 19:24:47 +00:00
Owner
Copy link

Following:
https://github.com/matrix-org/synapse/blob/develop/docs/metrics-howto.md

Following: https://github.com/matrix-org/synapse/blob/develop/docs/metrics-howto.md
teutat3s self-assigned this 2024-01-25 19:24:47 +00:00
teutat3s added 1 commit 2024-01-25 19:24:47 +00:00
feat(matrix-synapse): enable metrics
All checks were successful
Flake checks / Check (pull_request) Successful in 18m40s
Details
ca1e52cb7a 
Following:
https://github.com/matrix-org/synapse/blob/develop/docs/metrics-howto.md
teutat3s requested review from b12f 2024-01-25 19:25:21 +00:00
teutat3s requested review from hensoko 2024-01-25 19:25:21 +00:00
teutat3s requested review from axeman 2024-01-25 19:25:21 +00:00
teutat3s added 1 commit 2024-01-27 10:20:20 +00:00
refactor(matrix-synapse): get first listener port
All checks were successful
Flake checks / Check (pull_request) Successful in 10m47s
Details
f8de0d4f67
axeman reviewed 2024-01-27 17:32:05 +00:00
hosts/nachtigall/apps/matrix/irc.nix Outdated
@ -1,4 +1,8 @@
{config, lib, pkgs, ...}:
let
# Get port from first element in list of matrix-synapse listeners
synapsePort = "${toString (lib.findFirst (listener: listener.port != null) "" config.services.matrix-synapse.settings.listeners).port}";
axeman commented 2024-01-27 17:32:05 +00:00
Owner
Copy link

This looks like it will break if someone adds things as the first element of that list. We should filter for the service which contains federation in names.

This looks like it will break if someone adds things as the first element of that list. We should filter for the service which contains `federation` in `names`.
teutat3s force-pushed feat/synapse-metrics from f8de0d4f67 to 2c6584cf26 2024-01-27 18:12:36 +00:00 Compare
teutat3s added 2 commits 2024-01-27 19:25:39 +00:00 
list of config.services.matrix-synapse.settings.listeners.*.resources
that sets names = "client" instead of just using the first element in the list of listeners
fix(matrix-synapse): make sure to find element in
Some checks failed
Flake checks / Check (pull_request) Failing after 3m26s
Details
450c82671a 
list of config.services.matrix-synapse.settings.listeners that sets
type = "metrics" instead of just using the first element in the list
teutat3s force-pushed feat/synapse-metrics from 450c82671a to 73e3a8c160 2024-01-27 19:35:53 +00:00 Compare
axeman approved these changes 2024-01-28 21:03:52 +00:00
axeman left a comment
Owner
Copy link

Looks good, ship it 🚀

Looks good, ship it 🚀
teutat3s force-pushed feat/synapse-metrics from 73e3a8c160 to 69b976607f 2024-01-28 23:45:22 +00:00 Compare
teutat3s merged commit b2e845876a into main 2024-01-28 23:56:42 +00:00
teutat3s deleted branch feat/synapse-metrics 2024-01-28 23:56:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
hensoko
b12f
axeman
Labels
Clear labels   
Bug

   
Docs

   
Feature request

   
Good for newcomers

   
Infra

   
Privacy

   
Refactoring or migration

   
Security
No labels
Bug
Docs
Feature request
Good for newcomers
Infra
Privacy
Refactoring or migration
Security
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
teutat3s
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pub-solar/infra#100
No description provided.
Delete branch "feat/synapse-metrics"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?