pub-solar/infra
6
1
Fork 3
Code Issues 23 Pull requests 10 Actions Packages Projects 1 Releases Wiki Activity

feat/tests #224

Merged
teutat3s merged 6 commits from feat/tests into main 2024-08-27 10:45:56 +00:00
Conversation 6 Commits 6 Files changed 20 +701 -35
b12f commented 2024-08-25 00:28:42 +00:00
Owner
Copy link
No description provided.
b12f added 7 commits 2024-08-25 00:28:42 +00:00
tests/keycloak: working base test without client
Some checks failed
Flake checks / Check (pull_request) Failing after 21s
Details
3d0e5063ac
teutat3s force-pushed feat/tests from 3d0e5063ac to 74f03555e5 2024-08-25 00:42:21 +00:00 Compare
teutat3s added 1 commit 2024-08-25 00:44:14 +00:00
keycloak: remove unneeded insecure exception
Some checks failed
Flake checks / Check (pull_request) Failing after 2m10s
Details
6ac401da21
b12f was assigned by teutat3s 2024-08-25 00:50:59 +00:00
teutat3s requested review from teutat3s 2024-08-25 00:51:06 +00:00
teutat3s requested review from hensoko 2024-08-25 00:51:06 +00:00
teutat3s requested review from axeman 2024-08-25 00:51:06 +00:00
b12f added 1 commit 2024-08-25 02:19:27 +00:00
tests: fix website test
Some checks failed
Flake checks / Check (pull_request) Failing after 2m17s
Details
fbb9dd8f17
b12f added 1 commit 2024-08-25 02:36:31 +00:00
modules/backup: fix unitOptions usage
Some checks failed
Flake checks / Check (pull_request) Failing after 21s
Details
45b0500f0f
teutat3s added 1 commit 2024-08-25 15:03:48 +00:00
style: format using nixfmt-rfc-style
All checks were successful
Flake checks / Check (pull_request) Successful in 6m16s
Details
a859061bf7
b12f added 1 commit 2024-08-25 15:05:23 +00:00
nachtigall: make postgres wait for zfs mount
All checks were successful
Flake checks / Check (pull_request) Successful in 5m23s
Details
cffd3d002e
teutat3s commented 2024-08-26 17:28:46 +00:00
Owner
Copy link

Testing changes for nachtigall looks good, expected 0 changes and:

❯ nix store diff-closures $OLD_CLOSURE $NEW_CLOSURE
source: +23.3 KiB
Testing changes for nachtigall looks good, expected 0 changes and: ``` ❯ nix store diff-closures $OLD_CLOSURE $NEW_CLOSURE source: +23.3 KiB ```
teutat3s added 3 commits 2024-08-26 18:06:56 +00:00 
terminology, update description
style: avoid toplevel 'with lib;' to avoid scoping issues
Some checks failed
Flake checks / Check (pull_request) Failing after 21s
Details
5556f65609
teutat3s added 1 commit 2024-08-26 18:45:56 +00:00
style: fix formatting
All checks were successful
Flake checks / Check (pull_request) Successful in 23m26s
Details
cdb7149dd4
teutat3s approved these changes 2024-08-26 18:47:28 +00:00
teutat3s left a comment
Owner
Copy link

Thanks for figuring this out!

Thanks for figuring this out!
hensoko commented 2024-08-26 20:44:13 +00:00
Owner
Copy link

Should we split tests, backup module introduction and changes to keycloak put into separate PRs? I can put the required effort into it.

@b12f

Should we split tests, backup module introduction and changes to keycloak put into separate PRs? I can put the required effort into it. @b12f
b12f commented 2024-08-26 21:23:36 +00:00
Author
Owner
Copy link

I don't see a need, especially because there's dependencies between them and I think it'll just be a bunch of busywork for you. Maybe @teutat3s has a different opinion

I don't see a need, especially because there's dependencies between them and I think it'll just be a bunch of busywork for you. Maybe @teutat3s has a different opinion
teutat3s commented 2024-08-27 07:29:59 +00:00
Owner
Copy link

Just rebase and squash to three commits to keep it more atomic?

Just rebase and squash to three commits to keep it more atomic?
b12f commented 2024-08-27 07:55:25 +00:00
Author
Owner
Copy link

Feel free to do that @hensoko I'm continuing in #174 right now and would like to keep moving forward

Feel free to do that @hensoko I'm continuing in https://git.pub.solar/pub-solar/infra/pulls/174 right now and would like to keep moving forward
teutat3s commented 2024-08-27 08:12:44 +00:00
Owner
Copy link

@hensoko Do you like it: https://git.pub.solar/pub-solar/infra/compare/main...feat/tests-squashed - I'll force push after your ok.

@hensoko Do you like it: https://git.pub.solar/pub-solar/infra/compare/main...feat/tests-squashed - I'll force push after your ok.
teutat3s force-pushed feat/tests from cdb7149dd4 to 88b76beb5c 2024-08-27 09:45:12 +00:00 Compare
teutat3s added 1 commit 2024-08-27 10:38:00 +00:00
ci: avoid garbage collection of checks
All checks were successful
Flake checks / Check (pull_request) Successful in 17m36s
Details
66ed87e666
teutat3s merged commit fb8ee1278a into main 2024-08-27 10:45:56 +00:00
teutat3s deleted branch feat/tests 2024-08-27 10:45:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
axeman
hensoko
teutat3s
Labels
Clear labels   
Bug

   
Docs

   
Feature request

   
Good for newcomers

   
Infra

   
Privacy

   
Refactoring or migration

   
Security
No labels
Bug
Docs
Feature request
Good for newcomers
Infra
Privacy
Refactoring or migration
Security
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b12f
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pub-solar/infra#224
No description provided.
Delete branch "feat/tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?