pub-solar/obs-portal
5
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Clean usernames of invalid characters when the users receive their name from the login server

Browse source
This commit is contained in:
Paul Bienkowski 2022-09-13 09:08:26 +02:00
parent 426e6c8593
commit dec165341b
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
api/obs/api/routes/login.py
View file

@ -1,5 +1,6 @@
import asyncio import asyncio
import logging import logging
import re
from requests.exceptions import RequestException from requests.exceptions import RequestException
@ -91,6 +92,15 @@ async def login_redirect(req):
preferred_username = userinfo["preferred_username"] preferred_username = userinfo["preferred_username"]
email = userinfo.get("email") email = userinfo.get("email")
clean_username = re.sub(r"[^a-zA-Z0-9_.-]", "", preferred_username)
if clean_username != preferred_username:
log.warning(
"Username %r contained invalid characters and was changed to %r",
preferred_username,
clean_username,
)
preferred_username = clean_username
if email is None: if email is None:
raise ValueError( raise ValueError(
"user has no email set, please configure keycloak to require emails" "user has no email set, please configure keycloak to require emails"