pub-solar/os
5
0
Fork 2
Code Issues 4 Pull requests Packages Projects 1 Releases Wiki Activity

NixOS module for a drone ci runner in docker #147

Merged
hensoko merged 3 commits from feature/add-module-to-run-kvm-capable-drone-runner-in-docker into main 2023-01-30 00:09:23 +00:00
Conversation 0 Commits 3 Files changed 1 +106
hensoko commented 2022-10-22 13:09:36 +00:00 (Migrated from git.b12f.io)
Copy link

Add module to run a drone exec runner within a docker container as user process by still providing kvm support

Add module to run a drone exec runner within a docker container as user process by still providing kvm support
b12f (Migrated from git.b12f.io) reviewed 2022-10-22 13:09:43 +00:00
teutat3s (Migrated from git.b12f.io) reviewed 2022-10-22 13:09:43 +00:00
axeman (Migrated from git.b12f.io) reviewed 2022-10-22 13:09:43 +00:00
teutat3s (Migrated from git.b12f.io) approved these changes 2022-10-24 08:30:42 +00:00
modules/docker-ci-runner/default.nix Outdated
@ -0,0 +43,4 @@
in
{
options.pub-solar.docker-ci-runner = {
enable = lib.mkEnableOption "Enables a docker container running a drone exec runner as unprivileged user.";
teutat3s (Migrated from git.b12f.io) commented 2022-10-24 08:30:42 +00:00
Copy link

Where can I find the mentioned systemd service, or did I miss something?

Where can I find the mentioned systemd service, or did I miss something?
teutat3s (Migrated from git.b12f.io) commented 2022-10-24 12:24:55 +00:00
Copy link

Haha kinda misleading. I will reword this. But a docker container is created and for that NixOS adds a docker-drone-ci-runner.service.

Haha kinda misleading. I will reword this. But a docker container is created and for that NixOS adds a docker-drone-ci-runner.service.
teutat3s (Migrated from git.b12f.io) reviewed 2022-10-24 09:23:45 +00:00
modules/docker-ci-runner/default.nix Outdated
@ -0,0 +36,4 @@
cp -a /run/vars /run/runtime-vars
env | grep "DRONE" >> /run/runtime-vars
su - -s /bin/bash build sh -c "/usr/local/bin/drone-runner-exec daemon /run/runtime-vars"
teutat3s (Migrated from git.b12f.io) commented 2022-10-24 09:23:45 +00:00
Copy link

Is this meant to be the same vars as in line 93? /run/runtime-vars vs. /run/vars?

Is this meant to be the same `vars` as in line 93? `/run/runtime-vars` vs. `/run/vars`?
teutat3s (Migrated from git.b12f.io) commented 2022-10-24 09:24:27 +00:00
Copy link

Ah, read two lines above, nvm :D

Ah, read two lines above, nvm :D
b12f (Migrated from git.b12f.io) reviewed 2022-10-29 20:40:32 +00:00
modules/docker-ci-runner/default.nix Outdated
@ -0,0 +56,4 @@
nixCacheLocation = lib.mkOption {
description = ''
Location of nix cache that is shared between builds
'';
b12f (Migrated from git.b12f.io) commented 2022-10-29 20:40:32 +00:00
Copy link

We should have a default here

We should have a default here
b12f (Migrated from git.b12f.io) commented 2022-10-29 20:56:33 +00:00
Copy link

Ack

Ack
modules/docker-ci-runner/default.nix Outdated
@ -0,0 +69,4 @@
};
runnerVarsFile = lib.mkOption {
description = ''
b12f (Migrated from git.b12f.io) commented 2022-10-29 20:47:35 +00:00
Copy link

I'd discuss age encryption here.

I'd discuss age encryption here.
b12f (Migrated from git.b12f.io) commented 2022-10-29 20:56:17 +00:00
Copy link

It is not necessarily age. It just requires a file to be used for vars which can also be provied like this

let
  secretsFile = pkgs.writeFile "vars" ''
    DRONE_ENVIRONMENT_VARIABLE = "I don´t know";
  '';
in
{
  pub-solar.modules.docker-ci-runner.runnerVarsFile = secretsFile;
}
It is not necessarily age. It just requires a file to be used for vars which can also be provied like this ``` let secretsFile = pkgs.writeFile "vars" '' DRONE_ENVIRONMENT_VARIABLE = "I don´t know"; ''; in { pub-solar.modules.docker-ci-runner.runnerVarsFile = secretsFile; } ```
b12f added 1 commit 2023-01-28 23:03:33 +00:00
Merge branch 'main' into feature/add-module-to-run-kvm-capable-drone-runner-in-docker
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
a1cc9ea05a
b12f approved these changes 2023-01-29 17:03:27 +00:00
b12f left a comment
Copy link

LGTM

LGTM
modules/docker-ci-runner/default.nix Outdated
@ -0,0 +43,4 @@
in
{
options.pub-solar.docker-ci-runner = {
enable = lib.mkEnableOption "Enables a docker container running a drone exec runner as unprivileged user.";
teutat3s (Migrated from git.b12f.io) commented 2022-10-24 08:30:42 +00:00
Copy link

Where can I find the mentioned systemd service, or did I miss something?

Where can I find the mentioned systemd service, or did I miss something?
teutat3s (Migrated from git.b12f.io) commented 2022-10-24 12:24:55 +00:00
Copy link

Haha kinda misleading. I will reword this. But a docker container is created and for that NixOS adds a docker-drone-ci-runner.service.

Haha kinda misleading. I will reword this. But a docker container is created and for that NixOS adds a docker-drone-ci-runner.service.
hensoko force-pushed feature/add-module-to-run-kvm-capable-drone-runner-in-docker from a1cc9ea05a to 25ad234f2a 2023-01-29 17:06:56 +00:00 Compare
hensoko merged commit a18a883500 into main 2023-01-30 00:09:23 +00:00
hensoko deleted branch feature/add-module-to-run-kvm-capable-drone-runner-in-docker 2023-01-30 00:09:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b12f
axeman
teutat3s
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pub-solar/os#147
No description provided.
Delete branch "feature/add-module-to-run-kvm-capable-drone-runner-in-docker"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?