Improve hibernation logic #148

Merged

hensoko merged 0 commits from refs/pull/148/head into main 2022-10-24 19:35:29 +00:00

Conversation 1 Commits - Files changed -

hensoko commented 2022-10-23 16:35:06 +00:00 (Migrated from git.b12f.io)

Copy link

• Make resume_offset optional

* Make `resume_offset` optional

b12f (Migrated from git.b12f.io) reviewed 2022-10-23 16:35:17 +00:00

teutat3s (Migrated from git.b12f.io) reviewed 2022-10-23 16:35:17 +00:00

axeman (Migrated from git.b12f.io) reviewed 2022-10-23 16:35:17 +00:00

teutat3s commented 2022-10-24 08:37:38 +00:00 (Migrated from git.b12f.io)

Copy link

Could this create broken hibernation setups? Maybe lib.trivial.warn could be used instead of builtins.abort?

Could this create broken hibernation setups? Maybe `lib.trivial.warn` could be used instead of `builtins.abort`?

b12f (Migrated from git.b12f.io) approved these changes 2022-10-24 19:35:24 +00:00

b12f (Migrated from git.b12f.io) left a comment

Copy link

LGTM

LGTM

teutat3s referenced this pull request from a commit 2022-11-29 01:43:44 +00:00

Merge pull request 'Improve hibernation logic' (#148) from feature/improve-hibernation-logic into main

Sign in to join this conversation.

Reviewers

No reviewers

axeman

teutat3s

b12f

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pub-solar/os#148

No description provided.