From 901463301cf1263ecce2ab0a71fd23dfc113cd33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joaqu=C3=ADn=20S=C3=A1nchez?= Date: Thu, 26 Jan 2023 21:30:39 +0100 Subject: [PATCH] feat(pwa): don't show install widget if cancelled from widget (#1459) --- constants/index.ts | 1 + plugins/pwa.client.ts | 72 +++++++++++++++++++++++-------------------- 2 files changed, 40 insertions(+), 33 deletions(-) diff --git a/constants/index.ts b/constants/index.ts index 0f836c8b..e98fcf64 100644 --- a/constants/index.ts +++ b/constants/index.ts @@ -18,6 +18,7 @@ export const STORAGE_KEY_HIDE_EXPLORE_NEWS_TIPS = 'elk-hide-explore-news-tips' export const STORAGE_KEY_HIDE_EXPLORE_TAGS_TIPS = 'elk-hide-explore-tags-tips' export const STORAGE_KEY_NOTIFICATION = 'elk-notification' export const STORAGE_KEY_NOTIFICATION_POLICY = 'elk-notification-policy' +export const STORAGE_KEY_PWA_HIDE_INSTALL = 'elk-pwa-hide-install' export const COOKIE_MAX_AGE = 10 * 365 * 24 * 60 * 60 * 1000 diff --git a/plugins/pwa.client.ts b/plugins/pwa.client.ts index 79e8c776..53671492 100644 --- a/plugins/pwa.client.ts +++ b/plugins/pwa.client.ts @@ -1,10 +1,12 @@ import { useRegisterSW } from 'virtual:pwa-register/vue' +import { STORAGE_KEY_PWA_HIDE_INSTALL } from '~/constants' export default defineNuxtPlugin(() => { const online = useOnline() const registrationError = ref(false) const swActivated = ref(false) const showInstallPrompt = ref(false) + const hideInstall = useLocalStorage(STORAGE_KEY_PWA_HIDE_INSTALL, false) // https://thomashunter.name/posts/2021-12-11-detecting-if-pwa-twa-is-installed const ua = navigator.userAgent @@ -58,42 +60,46 @@ export default defineNuxtPlugin(() => { needRefresh.value = false } - type InstallPromptEvent = Event & { - prompt: () => void - userChoice: Promise<{ outcome: 'dismissed' | 'accepted' }> - } + let install: () => Promise = () => Promise.resolve() + let cancelInstall: () => void = noop - let deferredPrompt: InstallPromptEvent | undefined - - const beforeInstallPrompt = (e: Event) => { - e.preventDefault() - deferredPrompt = e as InstallPromptEvent - showInstallPrompt.value = true - } - window.addEventListener('beforeinstallprompt', beforeInstallPrompt) - window.addEventListener('appinstalled', () => { - deferredPrompt = undefined - showInstallPrompt.value = false - }) - - const cancelInstall = () => { - deferredPrompt = undefined - showInstallPrompt.value = false - window.removeEventListener('beforeinstallprompt', beforeInstallPrompt) - } - - const install = async () => { - if (!showInstallPrompt.value || !deferredPrompt) { - showInstallPrompt.value = false - return + if (!hideInstall.value) { + type InstallPromptEvent = Event & { + prompt: () => void + userChoice: Promise<{ outcome: 'dismissed' | 'accepted' }> } - showInstallPrompt.value = false - await nextTick() - deferredPrompt.prompt() - const { outcome } = await deferredPrompt.userChoice - if (outcome === 'dismissed') - cancelInstall() + let deferredPrompt: InstallPromptEvent | undefined + + const beforeInstallPrompt = (e: Event) => { + e.preventDefault() + deferredPrompt = e as InstallPromptEvent + showInstallPrompt.value = true + } + window.addEventListener('beforeinstallprompt', beforeInstallPrompt) + window.addEventListener('appinstalled', () => { + deferredPrompt = undefined + showInstallPrompt.value = false + }) + + cancelInstall = () => { + deferredPrompt = undefined + showInstallPrompt.value = false + window.removeEventListener('beforeinstallprompt', beforeInstallPrompt) + hideInstall.value = true + } + + install = async () => { + if (!showInstallPrompt.value || !deferredPrompt) { + showInstallPrompt.value = false + return + } + + showInstallPrompt.value = false + await nextTick() + deferredPrompt.prompt() + await deferredPrompt.userChoice + } } return {