teutat3s/elk
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

fix(ui): don't scroll on settings item click when external or _blank target link (#2742)

Browse source
This commit is contained in:
Joaquín Sánchez 2024-04-03 15:59:42 +02:00 committed by GitHub
parent 59dda09cd4
commit bead2183b2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
components/settings/SettingsItem.vue
View file

@ -10,9 +10,11 @@ const props = defineProps<{
external?: true external?: true
large?: true large?: true
match?: boolean match?: boolean
target?: string
}>() }>()
const router = useRouter() const router = useRouter()
const scrollOnClick = computed(() => props.to && !(props.target === '_blank' || props.external))
useCommand({ useCommand({
scope: 'Settings', scope: 'Settings',
@ -39,11 +41,12 @@ useCommand({
:disabled="disabled" :disabled="disabled"
:to="to" :to="to"
:external="external" :external="external"
:target="target"
exact-active-class="text-primary" exact-active-class="text-primary"
:class="disabled ? 'op25 pointer-events-none ' : match ? 'text-primary' : ''" :class="disabled ? 'op25 pointer-events-none ' : match ? 'text-primary' : ''"
block w-full group focus:outline-none block w-full group focus:outline-none
:tabindex="disabled ? -1 : null" :tabindex="disabled ? -1 : null"
@click="to ? $scrollToTop() : undefined" @click="scrollOnClick ? $scrollToTop() : undefined"
> >
<div <div
w-full flex px5 py3 md:gap2 gap4 items-center w-full flex px5 py3 md:gap2 gap4 items-center