perf: cache userSettings, improve #1013

composables/users.ts

@@ -1,6 +1,6 @@
 import { createClient, fetchV1Instance } from 'masto'
 import type { mastodon } from 'masto'
-import type { Ref } from 'vue'
+import type { EffectScope, Ref } from 'vue'
 import type { MaybeComputedRef, RemovableRef } from '@vueuse/core'
 import type { ElkMasto, UserLogin } from '~/types'
 import {
@@ -266,10 +266,21 @@ export function checkLogin() {
   return true
 }
 
+interface UseUserLocalStorageCache {
+  scope: EffectScope
+  value: Ref<Record<string, any>>
+}
+
 /**
  * Create reactive storage for the current user
  */
 export function useUserLocalStorage<T extends object>(key: string, initial: () => T) {
+  // @ts-expect-error bind value to the function
+  const map: Map<string, UseUserLocalStorageCache> = useUserLocalStorage._ = useUserLocalStorage._ || new Map()
+
+  if (!map.has(key)) {
+    const scope = effectScope(true)
+    const value = scope.run(() => {
       const all = useLocalStorage<Record<string, T>>(key, {}, { deep: true })
       return computed(() => {
         const id = currentUser.value?.account.id
@@ -278,6 +289,11 @@ export function useUserLocalStorage<T extends object>(key: string, initial: () =
         all.value[id] = Object.assign(initial(), all.value[id] || {})
         return all.value[id]
       })
+    })
+    map.set(key, { scope, value: value! })
+  }
+
+  return map.get(key)!.value
 }
 
 /**
@@ -290,10 +306,12 @@ export function clearUserLocalStorage(account?: mastodon.v1.Account) {
     return
 
   const id = `${account.acct}@${currentInstance.value?.uri || currentServer.value}`
+
   // @ts-expect-error bind value to the function
-  ;(useUserLocalStorage._ as Map<string, Ref<Record<string, any>>> | undefined)?.forEach((storage) => {
+  const cacheMap = useUserLocalStorage._ as Map<string, UseUserLocalStorageCache> | undefined
-    if (storage.value[id])
+  cacheMap?.forEach(({ value }) => {
-      delete storage.value[id]
+    if (value.value[id])
+      delete value.value[id]
   })
 }
 

error.vue

@@ -11,6 +11,9 @@ const errorCodes: Record<number, string> = {
   404: 'Page not found',
 }
 
+if (process.dev)
+  console.error(error)
+
 const defaultMessage = 'Something went wrong'
 
 const message = error.message ?? errorCodes[error.statusCode!] ?? defaultMessage

plugins/setup-head-script.server.ts

@@ -11,15 +11,13 @@ export default defineNuxtPlugin(() => {
         innerHTML: `
 ;(function() {
   const handle = localStorage.getItem('${STORAGE_KEY_CURRENT_USER_HANDLE}')
-  if (!handle)
+  if (!handle) { return }
-    return
   const allSettings = JSON.parse(localStorage.getItem('${STORAGE_KEY_SETTINGS}') || '{}')
   const settings = allSettings[handle]
-  if (!settings)
+  if (!settings) { return }
-    return
 
   const html = document.querySelector('html')
-  ${process.dev ? 'console.log(\'settings\', settings)' : ''}
+  ${process.dev ? 'console.log({ settings })' : ''}
 
   const { fontSize, language } = settings || {}