zaubentrucker/muele-marlin
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Fixed bug that makes ulticontroller knob backwards introduced Feb 28 2013 by Robert.

Browse source 
Bug introduced in version 6beb42cdf6.
Robert did a good job of simplifying but messed up this chunk of code.

Looking at working version: 839bef6d5d
it seems there is no case where encrot3 should be defined as 2
because if ULTICONTROLLER is defined then NEWPANEL is also defined.
This commit is contained in:
George Roberts 2013-09-10 09:56:19 -04:00
parent d78db12abd
commit 595580556c
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Marlin/ultralcd_implementation_hitachi_HD44780.h
View file

@ -128,17 +128,10 @@ extern volatile uint16_t buttons; //an extended version of the last checked but
// These values are independent of which pins are used for EN_A and EN_B indications // These values are independent of which pins are used for EN_A and EN_B indications
// The rotary encoder part is also independent to the chipset used for the LCD // The rotary encoder part is also independent to the chipset used for the LCD
#if defined(EN_A) && defined(EN_B) #if defined(EN_A) && defined(EN_B)
#ifndef ULTIMAKERCONTROLLER
#define encrot0 0 #define encrot0 0
#define encrot1 2 #define encrot1 2
#define encrot2 3 #define encrot2 3
#define encrot3 1 #define encrot3 1
#else
#define encrot0 0
#define encrot1 1
#define encrot2 3
#define encrot3 2
#endif
#endif #endif
#endif //ULTIPANEL #endif //ULTIPANEL