From 99592c84584539fb42eec447909518bc18eb4b2f Mon Sep 17 00:00:00 2001 From: LVD-AC Date: Mon, 26 Jun 2017 12:25:57 +0200 Subject: [PATCH] Update G33: Add F, fix height bug --- Marlin/Marlin_main.cpp | 56 ++++++++++++++++++++++++++++-------------- 1 file changed, 37 insertions(+), 19 deletions(-) diff --git a/Marlin/Marlin_main.cpp b/Marlin/Marlin_main.cpp index bf5ab60467..1ec9210ca4 100644 --- a/Marlin/Marlin_main.cpp +++ b/Marlin/Marlin_main.cpp @@ -1772,8 +1772,9 @@ static void clean_up_after_endstop_or_probe_move() { float z_dest = LOGICAL_Z_POSITION(z_raise); if (zprobe_zoffset < 0) z_dest -= zprobe_zoffset; + #if ENABLED(DELTA) - z_dest -= home_offset[Z_AXIS]; + z_dest -= home_offset[Z_AXIS]; // Account for delta height adjustment #endif if (z_dest > current_position[Z_AXIS]) @@ -2263,9 +2264,11 @@ static void clean_up_after_endstop_or_probe_move() { // move down quickly before doing the slow probe float z = LOGICAL_Z_POSITION(Z_CLEARANCE_BETWEEN_PROBES); if (zprobe_zoffset < 0) z -= zprobe_zoffset; + #if ENABLED(DELTA) - z -= home_offset[Z_AXIS]; + z -= home_offset[Z_AXIS]; // Account for delta height adjustment #endif + if (z < current_position[Z_AXIS]) do_blocking_move_to_z(z, MMM_TO_MMS(Z_PROBE_SPEED_FAST)); @@ -2285,7 +2288,11 @@ static void clean_up_after_endstop_or_probe_move() { SERIAL_ECHOLNPAIR(" Discrepancy:", first_probe_z - current_position[Z_AXIS]); } #endif - return RAW_CURRENT_POSITION(Z) + zprobe_zoffset; + return RAW_CURRENT_POSITION(Z) + zprobe_zoffset + #if ENABLED(DELTA) + + home_offset[Z_AXIS] // Account for delta height adjustment + #endif + ; } /** @@ -5134,6 +5141,8 @@ void home_all_axes() { gcode_G28(true); } * T Don't calibrate tower angle corrections * * Cn.nn Calibration precision; when omitted calibrates to maximum precision + * + * Fn Force to run at least n iterations and takes the best result * * Vn Verbose level: * @@ -5172,7 +5181,13 @@ void home_all_axes() { gcode_G28(true); } return; } - const bool towers_set = !parser.seen('T'), + const int8_t force_iterations = parser.seen('F') ? parser.value_int() : 1; + if (!WITHIN(force_iterations, 1, 30)) { + SERIAL_PROTOCOLLNPGM("?(F)orce iteration is implausible (1-30)."); + return; + } + + const bool towers_set = !parser.seen('T'), stow_after_each = parser.seen('E') && parser.value_bool(), _1p_calibration = probe_points == 1, _4p_calibration = probe_points == 2, @@ -5206,6 +5221,7 @@ void home_all_axes() { gcode_G28(true); } float test_precision, zero_std_dev = (verbose_level ? 999.0 : 0.0), // 0.0 in dry-run mode : forced end zero_std_dev_old = zero_std_dev, + zero_std_dev_min = zero_std_dev, e_old[XYZ] = { endstop_adj[A_AXIS], endstop_adj[B_AXIS], @@ -5284,9 +5300,10 @@ void home_all_axes() { gcode_G28(true); } const uint8_t start = _4p_opposite_points ? 3 : 1, step = _4p_calibration ? 4 : _7p_half_circle ? 2 : 1; for (uint8_t axis = start; axis < 13; axis += step) { - const float offset_circles = _7p_quadruple_circle ? (zig_zag ? 1.5 : 1.0) : - _7p_triple_circle ? (zig_zag ? 1.0 : 0.5) : - _7p_double_circle ? (zig_zag ? 0.5 : 0.0) : 0; + const float zigadd = (zig_zag ? 0.5 : 0.0), + offset_circles = _7p_quadruple_circle ? zigadd + 1.0 : + _7p_triple_circle ? zigadd + 0.5 : + _7p_double_circle ? zigadd : 0; for (float circles = -offset_circles ; circles <= offset_circles; circles++) { const float a = RADIANS(180 + 30 * axis), r = delta_calibration_radius * (1 + circles * (zig_zag ? 0.1 : -0.1)); @@ -5310,18 +5327,19 @@ void home_all_axes() { gcode_G28(true); } N++; } zero_std_dev_old = zero_std_dev; - zero_std_dev = round(SQRT(S2 / N) * 1000.0) / 1000.0 + 0.00001; - - if (iterations == 1) home_offset[Z_AXIS] = zh_old; // reset height after 1st probe change + NOMORE(zero_std_dev_min, zero_std_dev); + zero_std_dev = round(sqrt(S2 / N) * 1000.0) / 1000.0 + 0.00001; // Solve matrices - if (zero_std_dev < test_precision && zero_std_dev > calibration_precision) { - COPY(e_old, endstop_adj); - dr_old = delta_radius; - zh_old = home_offset[Z_AXIS]; - alpha_old = delta_tower_angle_trim[A_AXIS]; - beta_old = delta_tower_angle_trim[B_AXIS]; + if ((zero_std_dev < test_precision && zero_std_dev > calibration_precision) || iterations <= force_iterations) { + if (zero_std_dev < zero_std_dev_min) { + COPY(e_old, endstop_adj); + dr_old = delta_radius; + zh_old = home_offset[Z_AXIS]; + alpha_old = delta_tower_angle_trim[A_AXIS]; + beta_old = delta_tower_angle_trim[B_AXIS]; + } float e_delta[XYZ] = { 0.0 }, r_delta = 0.0, t_alpha = 0.0, t_beta = 0.0; const float r_diff = delta_radius - delta_calibration_radius, @@ -5420,7 +5438,7 @@ void home_all_axes() { gcode_G28(true); } } } if (test_precision != 0.0) { // !forced end - if (zero_std_dev >= test_precision || zero_std_dev <= calibration_precision) { // end iterations + if ((zero_std_dev >= test_precision || zero_std_dev <= calibration_precision) && iterations > force_iterations) { // end iterations SERIAL_PROTOCOLPGM("Calibration OK"); SERIAL_PROTOCOL_SP(36); if (zero_std_dev >= test_precision) @@ -5458,7 +5476,7 @@ void home_all_axes() { gcode_G28(true); } SERIAL_PROTOCOLPGM(" Tz:+0.00"); SERIAL_EOL(); } - if (zero_std_dev >= test_precision || zero_std_dev <= calibration_precision) + if ((zero_std_dev >= test_precision || zero_std_dev <= calibration_precision) && iterations > force_iterations) serialprintPGM(save_message); SERIAL_EOL(); } @@ -5485,7 +5503,7 @@ void home_all_axes() { gcode_G28(true); } endstops.not_homing(); } - while (zero_std_dev < test_precision && zero_std_dev > calibration_precision && iterations < 31); + while ((zero_std_dev < test_precision && zero_std_dev > calibration_precision && iterations < 31) || iterations <= force_iterations); #if ENABLED(DELTA_HOME_TO_SAFE_ZONE) do_blocking_move_to_z(delta_clip_start_height);