b12f/nixpkgs
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

ndi: unpackPhase without interpolation of src

Browse source 
The `unpackPhase` as of the previous commit did interpolate the result of the `src` on a nix level.
However for any overrides (`overrideAttrs`) to work on the source, for instance to update to a newer version locally, the `src` environment variable of `stdenv` must be used.
Otherwise the old, upstream, version will still be pulled in as a dependency and ultimately used for building, which will fail if the old version is not present, or will just deploy the old version if the old version was already downloaded (`requireFile` causes special semi-non-idempotent issues here).

Further information was provided in a GitHub comment: https://github.com/NixOS/nixpkgs/issues/219578#issuecomment-1586322972

Signed-off-by: benaryorg <binary@benary.org>
This commit is contained in:
benaryorg 2023-06-11 20:11:45 +00:00
parent 7cce8b10e8
commit 6b74da4cc3
No known key found for this signature in database
GPG key ID: 7A06724E5B00E546
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkgs/development/libraries/ndi/default.nix
View file

@ -28,7 +28,7 @@ stdenv.mkDerivation rec {
buildInputs = [ avahi ];
unpackPhase = ''
unpackFile ${src}
unpackFile $src
echo y | ./${installerName}.sh
sourceRoot="NDI SDK for Linux";
'';