b12f/nixpkgs
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Merge pull request #259072 from cbrewster/nsc-darwin

Browse source 
nsc: disable check phase on darwin
This commit is contained in:
Weijia Wang 2023-10-07 03:35:26 +02:00 committed by GitHub
parent 5d0346852c 47a059731e
commit d24eebdc98
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
pkgs/tools/system/nsc/default.nix
View file

@ -39,12 +39,22 @@ buildGoModule rec {
export HOME=$(mktemp -d)
'';
# Tests currently fail on darwin because of a test in nsc which
# expects command output to contain a specific path. However
# the test strips table formatting from the command output in a naive way
# that removes all the table characters, including '-'.
# The nix build directory looks something like:
# /private/tmp/nix-build-nsc-2.8.1.drv-0/nsc_test2000598938/keys
# Then the `-` are removed from the path unintentionally and the test fails.
# This should be fixed upstream to avoid mangling the path when
# removing the table decorations from the command output.
doCheck = !stdenv.isDarwin;
meta = {
description = "A tool for creating NATS account and user access configurations";
homepage = "https://github.com/nats-io/nsc";
license = with lib.licenses; [ asl20 ];
maintainers = with lib.maintainers; [ cbrewster ];
mainProgram = "nsc";
broken = stdenv.isDarwin;
};
}