b12f/nixpkgs
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

CONTRIBUTING.md: Move boot loader-specific sentence to pkgs/README.md

Browse source 
This needs a rewrite at some point..
This commit is contained in:
Silvan Mosberger 2023-08-14 19:03:56 +02:00
parent 2ce1e0b2cc
commit de5a39f5e7
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CONTRIBUTING.md
View file

@ -506,8 +506,6 @@ To get a sense for what changes are considered mass rebuilds, see [previously me
## Commit conventions
[commit-conventions]: #commit-conventions
- When changing the bootloader installation process, extra care must be taken. Grub installations cannot be rolled back, hence changes may break people’s installations forever. For any non-trivial change to the bootloader please file a PR asking for review, especially from \@edolstra.
- Create a commit for each logical unit.
- Check for unnecessary whitespace with `git diff --check` before committing.

2
nixos/README.md
View file

@ -10,6 +10,8 @@ You can add new module to your NixOS configuration file (usually it’s `/etc/ni
## Reviewing contributions
When changing the bootloader installation process, extra care must be taken. Grub installations cannot be rolled back, hence changes may break people’s installations forever. For any non-trivial change to the bootloader please file a PR asking for review, especially from \@edolstra.
### Module updates
Module updates are submissions changing modules in some ways. These often contains changes to the options or introduce new options.